Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2612423003: [ios] Fixed memory management bug in TestJavaScriptDialogPresenter. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed memory management bug in TestJavaScriptDialogPresenter. Copy strings before passing them to scoped_nsobjects. BUG=679032 Review-Url: https://codereview.chromium.org/2612423003 Cr-Commit-Position: refs/heads/master@{#442093} Committed: https://chromium.googlesource.com/chromium/src/+/1d41c27d99e1f50349bee096fa92efe91635c9f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/web/public/test/fakes/test_java_script_dialog_presenter.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-06 23:14:34 UTC) #3
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-06 23:16:42 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-06 23:18:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612423003/1
3 years, 11 months ago (2017-01-06 23:21:17 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 23:27:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d41c27d99e1f50349bee096fa92...

Powered by Google App Engine
This is Rietveld 408576698