Track composition range information on the browser side (Android)

Track composition range information on the browser side (Android)

This CL implements the logic to track composition range information
from several RenderWidgets on the same page (i.e., pages with OOPIFs) for Android platforms.

The tracking logic is now shared between RenderWidgetHostViewBase and TextInputManager,
while RenderWidgetHostViewAndroid observes TextInputManager for any 
changes to the range info in one of the RenderWidgets in the page.
This has already been implemented for Mac
(https://codereview.chromium.org/2235283003/) and Aura
(https://codereview.chromium.org/2132633002/) platforms.

An interactive test is now activated on all platform which will be
handy if/when interactive browser tests run on Android.

BUG=578168, 602723
Review-Url: https://codereview.chromium.org/2612423002
Cr-Commit-Position: refs/heads/master@{#443577}
Committed: https://chromium.googlesource.com/chromium/src/+/5f6b70eb67a2f1633ca5fcaa04374f7abd8c000c

[EhsanK, 2017-01-06 01:00:48]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:02:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2017-01-06 01:02:43]

Description was changed from

==========
Track composition range information on the browser side (Android)

This CL implements the logic to track composition range information
from several RenderWidgets on the same page (i.e., pages with OOPIFs) for
Android platforms.

The tracking logic is now shared between RenderWidgetHostViewBase and
TextInputManager, while RenderWidgetHostViewAndroid observes
TextInputManager for any changes to the range info in one of the
RenderWidgets in the page. This has already been implemented
for Mac (https://codereview.chromium.org/2235283003/) and Aura
(https://codereview.chromium.org/2132633002/) platforms.

An interactive test is now activated on all platform which will be handy if/when
interactive browser tests run on Android.

BUG=578168, 602723
==========

to

==========
Track composition range information on the browser side (Android)

This CL implements the logic to track composition range information
from several RenderWidgets on the same page (i.e., pages with OOPIFs) for
Android platforms.

The tracking logic is now shared between RenderWidgetHostViewBase and
TextInputManager,
while RenderWidgetHostViewAndroid observes TextInputManager for any 
changes to the range info in one of the RenderWidgets in the page.
This has already been implemented for Mac
(https://codereview.chromium.org/2235283003/) and Aura
(https://codereview.chromium.org/2132633002/) platforms.

An interactive test is now activated on all platform which will be
handy if/when interactive browser tests run on Android.

BUG=578168, 602723
==========

[EhsanK, 2017-01-06 01:07:57]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org, kenrb@chromium.org, shuchen@chromium.org

[EhsanK, 2017-01-06 01:07:58]

Hello,

Could you please take a look at this change?

creis@: content/ changes and test file + owner permission.
kenrb@: IME review.
shuchen@: Android IME review.

Thanks!

[commit-bot: I haz the power, 2017-01-06 02:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:06:22]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-01-06 22:22:40]

Thanks!  LGTM.

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:793:
std::vector<gfx::RectF> character_bounds_float;
nit: character_bounds

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:794: for (const
gfx::Rect& rect : info->character_bounds) {
nit: No braces needed.

[EhsanK, 2017-01-06 22:37:17]

Thanks Charlie!

Shu Chen: Could you please take a look (esp. since this is related to Android
IME)?

Thanks!

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:793:
std::vector<gfx::RectF> character_bounds_float;
On 2017/01/06 22:22:39, Charlie Reis wrote:
> nit: character_bounds

Acknowledged.

https://codereview.chromium.org/2612423002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:794: for (const
gfx::Rect& rect : info->character_bounds) {
On 2017/01/06 22:22:40, Charlie Reis wrote:
> nit: No braces needed.

Acknowledged.

[Shu Chen, 2017-01-11 03:45:06]

lgtm

[EhsanK, 2017-01-11 04:21:42]

Thanks shuchen@ for the reviews!

I will try to CQ soon.

[EhsanK, 2017-01-11 04:22:09]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 04:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 05:57:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 05:57:20]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[EhsanK, 2017-01-11 23:25:54]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:27:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:59:51]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2017-01-13 15:53:21]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2017-01-13 15:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2612423002/#ps20001
(title: "Addressing creis@'s comments")

[commit-bot: I haz the power, 2017-01-13 15:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 16:43:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484322801258350,
"parent_rev": "9d7ae4d5ebc6a01a9c443d91c86f788ae2815ddc", "commit_rev":
"5f6b70eb67a2f1633ca5fcaa04374f7abd8c000c"}

[commit-bot: I haz the power, 2017-01-13 16:44:53]

Description was changed from

==========
Track composition range information on the browser side (Android)

This CL implements the logic to track composition range information
from several RenderWidgets on the same page (i.e., pages with OOPIFs) for
Android platforms.

The tracking logic is now shared between RenderWidgetHostViewBase and
TextInputManager,
while RenderWidgetHostViewAndroid observes TextInputManager for any 
changes to the range info in one of the RenderWidgets in the page.
This has already been implemented for Mac
(https://codereview.chromium.org/2235283003/) and Aura
(https://codereview.chromium.org/2132633002/) platforms.

An interactive test is now activated on all platform which will be
handy if/when interactive browser tests run on Android.

BUG=578168, 602723
==========

to

==========
Track composition range information on the browser side (Android)

This CL implements the logic to track composition range information
from several RenderWidgets on the same page (i.e., pages with OOPIFs) for
Android platforms.

The tracking logic is now shared between RenderWidgetHostViewBase and
TextInputManager,
while RenderWidgetHostViewAndroid observes TextInputManager for any 
changes to the range info in one of the RenderWidgets in the page.
This has already been implemented for Mac
(https://codereview.chromium.org/2235283003/) and Aura
(https://codereview.chromium.org/2132633002/) platforms.

An interactive test is now activated on all platform which will be
handy if/when interactive browser tests run on Android.

BUG=578168, 602723

Review-Url: https://codereview.chromium.org/2612423002
Cr-Commit-Position: refs/heads/master@{#443577}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f6b70eb67a2f1633ca5fcaa0437...
==========

[commit-bot: I haz the power, 2017-01-13 16:44:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f6b70eb67a2f1633ca5fcaa0437...