Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2612373002: [cleanup] Remove unused runtime error functions/messages (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove unused runtime error functions/messages R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2612373002 Cr-Commit-Position: refs/heads/master@{#42103} Committed: https://chromium.googlesource.com/v8/v8/+/b54c825fd14f872aa210291b52cc2d8c13ff4999

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix golden files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -23 lines) Patch
M src/messages.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
adamk
3 years, 11 months ago (2017-01-05 22:21:18 UTC) #1
gsathya
lgtm
3 years, 11 months ago (2017-01-05 22:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612373002/20001
3 years, 11 months ago (2017-01-05 22:41:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/10601) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-05 22:59:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612373002/40001
3 years, 11 months ago (2017-01-05 23:20:19 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 23:46:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b54c825fd14f872aa210291b52cc2d8c13f...

Powered by Google App Engine
This is Rietveld 408576698