Gtk3: Fix background colors

Gtk3: Fix background colors

This CL fixes the selection color on Ambiance being darker than it's
supposed to be.

The reason this was broken is the Ambiance theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2612363004
Cr-Commit-Position: refs/heads/master@{#442020}
Committed: https://chromium.googlesource.com/chromium/src/+/d555bf3a479c5d7e14f5d49c0816302574891204

[Tom (Use chromium acct), 2017-01-06 02:09:10]

Patchset #1 (id:1) has been deleted

[Tom (Use chromium acct), 2017-01-06 02:12:58]

Description was changed from

==========
Gtk3: Fix background colors

This CL fixes the selection color when using the Adwaita theme being
slightly darker than it's supposed to be.

The reason this was broken is the Adwaita theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix background colors

This CL fixes the selection color on Ambiance being darker than it's
supposed to be.

The reason this was broken is the Ambiance theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org
==========

[Elliot Glaysher, 2017-01-06 18:58:42]

lgtm

[Tom (Use chromium acct), 2017-01-06 19:03:00]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-01-06 19:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:10:16]

CQ is committing da patch.

Bot data: {"patchset_id": 10002, "attempt_start_ts": 1483729380564600,
"parent_rev": "04dfcb1181a51812ff71c93ffc3853e01e60bdf3", "commit_rev":
"d555bf3a479c5d7e14f5d49c0816302574891204"}

[commit-bot: I haz the power, 2017-01-06 20:10:47]

Description was changed from

==========
Gtk3: Fix background colors

This CL fixes the selection color on Ambiance being darker than it's
supposed to be.

The reason this was broken is the Ambiance theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix background colors

This CL fixes the selection color on Ambiance being darker than it's
supposed to be.

The reason this was broken is the Ambiance theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2612363004
Cr-Commit-Position: refs/heads/master@{#442020}
Committed:
https://chromium.googlesource.com/chromium/src/+/d555bf3a479c5d7e14f5d49c0816...
==========

[commit-bot: I haz the power, 2017-01-06 20:10:48]

Committed patchset #1 (id:10002) as
https://chromium.googlesource.com/chromium/src/+/d555bf3a479c5d7e14f5d49c0816...