Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2612363003: DevTools: Show FMP markers on timeline experiment (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index e8295faea7b6b102e17af9bb1b1fd21d20fc2381..a1000df4fd390d5595b81768f89ecde5b5d2d310 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -1638,13 +1638,13 @@ Timeline.TimelineUIUtils = class {
* @return {!Timeline.TimelineMarkerStyle}
*/
static markerStyleForEvent(event) {
- var red = 'rgb(255, 0, 0)';
- var blue = 'rgb(0, 0, 255)';
- var orange = 'rgb(255, 178, 23)';
- var green = 'rgb(0, 130, 0)';
- var tallMarkerDashStyle = [10, 5];
-
- var title = Timeline.TimelineUIUtils.eventTitle(event);
+ const red = 'rgb(255, 0, 0)';
+ const blue = 'rgb(0, 0, 255)';
+ const orange = 'rgb(255, 178, 23)';
+ const green = 'rgb(0, 130, 0)';
+ const purple = '#a2f';
+ const tallMarkerDashStyle = [10, 5];
+ const title = Timeline.TimelineUIUtils.eventTitle(event);
if (event.hasCategory(TimelineModel.TimelineModel.Category.Console) ||
event.hasCategory(TimelineModel.TimelineModel.Category.UserTiming)) {
@@ -1676,6 +1676,9 @@ Timeline.TimelineUIUtils = class {
case recordTypes.TimeStamp:
color = orange;
break;
+ case recordTypes.FMPCandidate:
+ color = purple;
+ break;
}
return {
title: title,

Powered by Google App Engine
This is Rietveld 408576698