third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js - Issue 2612363003: DevTools: Show FMP markers on timeline experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2612363003: DevTools: Show FMP markers on timeline experiment (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/main/Main.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

index 74fbe009aca354268a04cb7b6c9940fcccfa24c6..cd3b8d8d71cb8b3aacd5c5c6e543bda5f8dc7dfd 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

@@ -108,6 +108,7 @@ TimelineModel.TimelineModel = class {

switch (event.name) {

case recordTypes.TimeStamp:

case recordTypes.MarkFirstPaint:

+ case recordTypes.FMPCandidate:

return true;

case recordTypes.MarkDOMContent:

case recordTypes.MarkLoad:

@@ -1197,6 +1198,7 @@ TimelineModel.TimelineModel.RecordType = {

MarkLoad: 'MarkLoad',

MarkDOMContent: 'MarkDOMContent',

MarkFirstPaint: 'MarkFirstPaint',

+ FMPCandidate: 'firstMeaningfulPaintCandidate',

pfeldman 2017/01/06 00:05:59 firstMeaningfulPaint also exists. And we can displ

alph 2017/01/06 01:56:48 Done.

TimeStamp: 'TimeStamp',

ConsoleTime: 'ConsoleTime',