[Chromecast] Fix AudioVideoPipelineDeviceTest failures

[Chromecast] Fix AudioVideoPipelineDeviceTest failures

The patch to add support for different playback rates had an error so that
sometimes the OnEndOfStream() callback was called before the last
OnPushBufferComplete() callback.

BUG= internal b/34093164
TEST= cast_media_unittests

Review-Url: https://codereview.chromium.org/2612353003
Cr-Commit-Position: refs/heads/master@{#441826}
Committed: https://chromium.googlesource.com/chromium/src/+/30714627739ff4d08c1621702fa70fe396cbb89d

[kmackay, 2017-01-05 23:16:29]

kmackay@chromium.org changed reviewers:
+ halliwell@chromium.org, mbjorge@chromium.org, slan@chromium.org

[mbjorge, 2017-01-05 23:32:35]

lgtm, but not too familiar with the alsa backend

[slan, 2017-01-06 01:14:47]

lgtm.

https://codereview.chromium.org/2612353003/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc (right):

https://codereview.chromium.org/2612353003/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc:242: if
(pending_buffer_complete_ && changed_sample_rate) {
This code is now liable to call OnPushBufferComplete when the rate_shifter_'s
queue is full. Is that OK?

[kmackay, 2017-01-06 01:21:04]

https://codereview.chromium.org/2612353003/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc (right):

https://codereview.chromium.org/2612353003/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc:242: if
(pending_buffer_complete_ && changed_sample_rate) {
On 2017/01/06 01:14:47, slan wrote:
> This code is now liable to call OnPushBufferComplete when the rate_shifter_'s
> queue is full. Is that OK?

In this case, the rate shifter was just (re)created, so its queue must be empty.

[kmackay, 2017-01-06 01:21:13]

The CQ bit was checked by kmackay@chromium.org

[commit-bot: I haz the power, 2017-01-06 01:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:19:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483665673807620, "parent_rev":
"8f2c67087919621e412ac9a5e82a2e719de80362", "commit_rev":
"30714627739ff4d08c1621702fa70fe396cbb89d"}

[commit-bot: I haz the power, 2017-01-06 02:19:41]

Description was changed from

==========
[Chromecast] Fix AudioVideoPipelineDeviceTest failures

The patch to add support for different playback rates had an error so that
sometimes the OnEndOfStream() callback was called before the last
OnPushBufferComplete() callback.

BUG= internal b/34093164
TEST= cast_media_unittests
==========

to

==========
[Chromecast] Fix AudioVideoPipelineDeviceTest failures

The patch to add support for different playback rates had an error so that
sometimes the OnEndOfStream() callback was called before the last
OnPushBufferComplete() callback.

BUG= internal b/34093164
TEST= cast_media_unittests

Review-Url: https://codereview.chromium.org/2612353003
Cr-Commit-Position: refs/heads/master@{#441826}
Committed:
https://chromium.googlesource.com/chromium/src/+/30714627739ff4d08c1621702fa7...
==========

[commit-bot: I haz the power, 2017-01-06 02:19:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30714627739ff4d08c1621702fa7...