Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2612323003: [Sync] Filter out types that can't be synced at configure time. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Filter out types that can't be synced at configure time. This replaces the previous check that was done inside SyncBackendRegistrar to see whether the corresponding workers for these types existed. BUG=663125 Review-Url: https://codereview.chromium.org/2612323003 Cr-Commit-Position: refs/heads/master@{#442003} Committed: https://chromium.googlesource.com/chromium/src/+/00f04a8ef2a691cb5f025c112f454f7138f0486b

Patch Set 1 #

Patch Set 2 : Fix bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -38 lines) Patch
M chrome/browser/sync/chrome_sync_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/sync/driver/data_type_manager_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M components/sync/driver/data_type_manager_impl.cc View 3 chunks +16 lines, -11 lines 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 6 chunks +11 lines, -17 lines 0 comments Download
M components/sync/driver/fake_sync_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/fake_sync_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/sync/driver/sync_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
maxbogue
Pavel, PTAL!
3 years, 11 months ago (2017-01-06 17:08:15 UTC) #10
pavely
lgtm
3 years, 11 months ago (2017-01-06 19:00:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612323003/20001
3 years, 11 months ago (2017-01-06 19:13:56 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:20:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00f04a8ef2a691cb5f025c112f45...

Powered by Google App Engine
This is Rietveld 408576698