Rename SpdyRstStreamStatus and SpdyGoAwayStatus enum entries.

Rename SpdyRstStreamStatus and SpdyGoAwayStatus enum entries.

Rename and renumber enum entries to exactly match wire values
defined in the HTTP/2 specification.  In particular:
* s/GOAWAY_OK/GOAWAY_NO_ERROR/
* s/RST_STREAM_INVALID_STREAM/RST_STREAM_STREAM_CLOSED/
* s/RST_STREAM_FRAME_TOO_LARGE/RST_STREAM_FRAME_SIZE_ERROR/
* Remove RST_STREAM_UNSUPPERTED_VERSION, RST_STREAM_IN_USE,
  RST_STREAM_ALREADY_CLOSED.

Change string serialization values only used for log messages.

RST_STREAM_INVALID_STREAM and RST_STREAM_STREAM_CLOSED were used
interchangeably.  Now RST_STREAM_INVALID_STREAM is removed in favor of
RST_STREAM_STREAM_CLOSED.  This CL also renames STATUS_CODE_INVALID_STREAM to
STATUS_CODE_STREAM_CLOSED, and changes description in histograms.xml.

Also add STATUS_CODE_COMPRESSION_ERROR to SpdyProtocolErrorDetails,
to correctly log incoming RST_STREAMs with RST_STREAM_COMPRESSION_ERROR.

This CL lands server change 143555862 by bnc.

BUG=488484
Review-Url: https://codereview.chromium.org/2612293004
Cr-Commit-Position: refs/heads/master@{#443002}
Committed: https://chromium.googlesource.com/chromium/src/+/5221fd1d6caa0d84ad5a0f8abb4bd745f0170b94

[Bence, 2017-01-06 15:41:35]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 15:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:03:12]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-01-06 18:16:31]

bnc@chromium.org changed reviewers:
+ isherman@chromium.org, rch@chromium.org

[Bence, 2017-01-06 18:16:31]

Ryan: PTAL at net/
Ilya: PTAL at tools/metrics/histograms/

Thank you both.

[Ilya Sherman, 2017-01-06 20:13:53]

histograms.xml lgtm

[Ryan Hamilton, 2017-01-10 22:47:02]

lgtm

[Bence, 2017-01-11 18:23:56]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-01-11 18:23:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2612293004/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-11 18:24:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:06:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484159036438530,
"parent_rev": "5d8ef24b4f241f165499751584bbbc0dfec51703", "commit_rev":
"5221fd1d6caa0d84ad5a0f8abb4bd745f0170b94"}

[commit-bot: I haz the power, 2017-01-11 22:06:52]

Description was changed from

==========
Rename SpdyRstStreamStatus and SpdyGoAwayStatus enum entries.

Rename and renumber enum entries to exactly match wire values
defined in the HTTP/2 specification.  In particular:
* s/GOAWAY_OK/GOAWAY_NO_ERROR/
* s/RST_STREAM_INVALID_STREAM/RST_STREAM_STREAM_CLOSED/
* s/RST_STREAM_FRAME_TOO_LARGE/RST_STREAM_FRAME_SIZE_ERROR/
* Remove RST_STREAM_UNSUPPERTED_VERSION, RST_STREAM_IN_USE,
  RST_STREAM_ALREADY_CLOSED.

Change string serialization values only used for log messages.

RST_STREAM_INVALID_STREAM and RST_STREAM_STREAM_CLOSED were used
interchangeably.  Now RST_STREAM_INVALID_STREAM is removed in favor of
RST_STREAM_STREAM_CLOSED.  This CL also renames STATUS_CODE_INVALID_STREAM to
STATUS_CODE_STREAM_CLOSED, and changes description in histograms.xml.

Also add STATUS_CODE_COMPRESSION_ERROR to SpdyProtocolErrorDetails,
to correctly log incoming RST_STREAMs with RST_STREAM_COMPRESSION_ERROR.

This CL lands server change 143555862 by bnc.

BUG=488484
==========

to

==========
Rename SpdyRstStreamStatus and SpdyGoAwayStatus enum entries.

Rename and renumber enum entries to exactly match wire values
defined in the HTTP/2 specification.  In particular:
* s/GOAWAY_OK/GOAWAY_NO_ERROR/
* s/RST_STREAM_INVALID_STREAM/RST_STREAM_STREAM_CLOSED/
* s/RST_STREAM_FRAME_TOO_LARGE/RST_STREAM_FRAME_SIZE_ERROR/
* Remove RST_STREAM_UNSUPPERTED_VERSION, RST_STREAM_IN_USE,
  RST_STREAM_ALREADY_CLOSED.

Change string serialization values only used for log messages.

RST_STREAM_INVALID_STREAM and RST_STREAM_STREAM_CLOSED were used
interchangeably.  Now RST_STREAM_INVALID_STREAM is removed in favor of
RST_STREAM_STREAM_CLOSED.  This CL also renames STATUS_CODE_INVALID_STREAM to
STATUS_CODE_STREAM_CLOSED, and changes description in histograms.xml.

Also add STATUS_CODE_COMPRESSION_ERROR to SpdyProtocolErrorDetails,
to correctly log incoming RST_STREAMs with RST_STREAM_COMPRESSION_ERROR.

This CL lands server change 143555862 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2612293004
Cr-Commit-Position: refs/heads/master@{#443002}
Committed:
https://chromium.googlesource.com/chromium/src/+/5221fd1d6caa0d84ad5a0f8abb4b...
==========

[commit-bot: I haz the power, 2017-01-11 22:06:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5221fd1d6caa0d84ad5a0f8abb4b...