[MediaSession] Don't reset metadata and actions when the session goes uncontrollable

[MediaSession] Don't reset metadata and actions when the session goes uncontrollable

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945
Review-Url: https://codereview.chromium.org/2612293003
Cr-Commit-Position: refs/heads/master@{#442708}
Committed: https://chromium.googlesource.com/chromium/src/+/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1

[Zhiqiang Zhang (Slow), 2017-01-06 16:38:19]

Description was changed from

==========
[MediaSession] Don't send reset signals for metadata ana actions when the
session goes uncontrollable

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945
==========

to

==========
[MediaSession] Don't reset metadata and actions when the session goes
uncontrollable

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945
==========

[Zhiqiang Zhang (Slow), 2017-01-06 16:38:45]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2017-01-09 15:59:20]

Does it mean that if the page sets src to "" or an unsupported format, we won't
remove/change the notification because we'll expect it to become controllable
soon?

The change doesn't make it clear that valid scenarios where the notification
needs to be updated is covered.

[Zhiqiang Zhang (Slow), 2017-01-09 16:17:41]

On 2017/01/09 15:59:20, whywhat wrote:
> Does it mean that if the page sets src to "" or an unsupported format, we
won't
> remove/change the notification because we'll expect it to become controllable
> soon?
> 
> The change doesn't make it clear that valid scenarios where the notification
> needs to be updated is covered.

The problem is that when session goes inactive, we send null metadata and then
"session uncontrollable" signal. Between these events, the displayed metadata
will flicker, especially the image.
The "session uncontrollable" signal will still be sent, however the metadata
reset is unnecessary. So the answer is no, because the notification will still
be hidden after this CL.

[Zhiqiang Zhang (Slow), 2017-01-10 13:06:36]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2017-01-10 13:06:37]

+mlamouri (I know Anton has some urgent work to do)

[mlamouri (slow - plz ping), 2017-01-10 14:25:20]

On 2017/01/09 at 16:17:41, zqzhang wrote:
> On 2017/01/09 15:59:20, whywhat wrote:
> > Does it mean that if the page sets src to "" or an unsupported format, we
won't
> > remove/change the notification because we'll expect it to become
controllable
> > soon?
> > 
> > The change doesn't make it clear that valid scenarios where the notification
> > needs to be updated is covered.
> 
> The problem is that when session goes inactive, we send null metadata and then
"session uncontrollable" signal. Between these events, the displayed metadata
will flicker, especially the image.
> The "session uncontrollable" signal will still be sent, however the metadata
reset is unnecessary. So the answer is no, because the notification will still
be hidden after this CL.

My understanding is that there will be no noticeable difference for the content.
The notification will still disappear when it should. It will help situations
where we delay hiding the notification slightly after it's uncontrollable. In
the current state, the notification will have reset metadata and be delayed.
zqzhang@, is that correct?

lgtm

[Zhiqiang Zhang (Slow), 2017-01-10 14:34:02]

On 2017/01/10 14:25:20, mlamouri wrote:
> My understanding is that there will be no noticeable difference for the
content.
> The notification will still disappear when it should. It will help situations
> where we delay hiding the notification slightly after it's uncontrollable. In
> the current state, the notification will have reset metadata and be delayed.
> zqzhang@, is that correct?

Yes :)

[whywhat, 2017-01-10 20:16:18]

lgtm

[Zhiqiang Zhang (Slow), 2017-01-10 20:53:06]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-01-10 20:53:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2612293003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-10 20:53:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 22:17:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484081586261720,
"parent_rev": "892aca45f80c04a7139ab07c7b1c9b9dd8349eec", "commit_rev":
"f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1"}

[commit-bot: I haz the power, 2017-01-10 22:18:22]

Description was changed from

==========
[MediaSession] Don't reset metadata and actions when the session goes
uncontrollable

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945
==========

to

==========
[MediaSession] Don't reset metadata and actions when the session goes
uncontrollable

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945

Review-Url: https://codereview.chromium.org/2612293003
Cr-Commit-Position: refs/heads/master@{#442708}
Committed:
https://chromium.googlesource.com/chromium/src/+/f64ef58c0294ed6ad7468c9ca715...
==========

[commit-bot: I haz the power, 2017-01-10 22:18:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f64ef58c0294ed6ad7468c9ca715...