Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Issue 2612263003: Don't run the variations broadcast receiver more than once. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run the variations broadcast receiver more than once. Turns out, it can be triggered multiple times even if it ran already on the same instance which was unregistered. I discovered this in https://codereview.chromium.org/2561433002 but want to submit this separately since in theory this issue can still exist without that (although much rarer, since usually there's only a single async activity). BUG=632199 Review-Url: https://codereview.chromium.org/2612263003 Cr-Commit-Position: refs/heads/master@{#441717} Committed: https://chromium.googlesource.com/chromium/src/+/91dde39f62bcd1c4e9803255d37c725c33557660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-05 15:43:05 UTC) #2
Ted C
lgtm
3 years, 11 months ago (2017-01-05 18:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612263003/1
3 years, 11 months ago (2017-01-05 18:17:39 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:53:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91dde39f62bcd1c4e9803255d37c...

Powered by Google App Engine
This is Rietveld 408576698