Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/core/dom/DOMRect.cpp

Issue 2612263002: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. (Closed)
Patch Set: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMRect.cpp
diff --git a/third_party/WebKit/Source/core/dom/DOMRect.cpp b/third_party/WebKit/Source/core/dom/DOMRect.cpp
index 26c811aed41d2c561861f176e5039465649bbe70..cda7989fc452f451a37269a11e5885acc1d37463 100644
--- a/third_party/WebKit/Source/core/dom/DOMRect.cpp
+++ b/third_party/WebKit/Source/core/dom/DOMRect.cpp
@@ -4,12 +4,18 @@
#include "core/dom/DOMRect.h"
zino 2017/01/14 17:11:33 nit: Please remove this line?
Byoungkwon Ko 2017/01/15 03:00:39 This is primary header. Plz take a look again. Tha
+#include "core/dom/DOMRectInit.h"
+
namespace blink {
DOMRect* DOMRect::create(double x, double y, double width, double height) {
return new DOMRect(x, y, width, height);
}
+DOMRect* DOMRect::fromRect(const DOMRectInit& other) {
+ return new DOMRect(other.x(), other.y(), other.width(), other.height());
zino 2017/01/14 17:11:33 nit: Please remove unnecessary blanks.
Byoungkwon Ko 2017/01/15 02:49:08 Done.
+}
+
DOMRect::DOMRect(double x, double y, double width, double height)
: DOMRectReadOnly(x, y, width, height) {}

Powered by Google App Engine
This is Rietveld 408576698