Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2612253003: Add visibility restrictions to all mojoms that export symbols. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, shalamov, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, Mikhail, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wanming.lin, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add visibility restrictions to all mojoms that export symbols. This brings those mojoms into line with the recommendations of https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md#Depending-on-a-source-set-or-static-library-from-both-inside-and-outside-a-component This also adds a |visiblity_blink| variable to mojom targets so they can limit visibility to the chromium and blink variants separately. BUG=636563 Review-Url: https://codereview.chromium.org/2612253003 Cr-Commit-Position: refs/heads/master@{#442193} Committed: https://chromium.googlesource.com/chromium/src/+/f5a9a71738b5016364f138e5b729f4d87221705f

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/generic_sensor/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Sam McNally
3 years, 11 months ago (2017-01-06 05:32:42 UTC) #10
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-06 18:26:19 UTC) #13
Sam McNally
+haraken for blink
3 years, 11 months ago (2017-01-08 23:33:19 UTC) #15
haraken
WebKit LGTM
3 years, 11 months ago (2017-01-09 01:39:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612253003/60001
3 years, 11 months ago (2017-01-09 02:00:02 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 03:56:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f5a9a71738b5016364f138e5b729...

Powered by Google App Engine
This is Rietveld 408576698