Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2612243002: Rename NewTabPagePrefs to RecentTabsPagePrefs. (Closed)

Created:
3 years, 11 months ago by Michael van Ouwerkerk
Modified:
3 years, 11 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename NewTabPagePrefs to RecentTabsPagePrefs. This class is only used for the RecentTabsPage. BUG=659631 Review-Url: https://codereview.chromium.org/2612243002 Cr-Commit-Position: refs/heads/master@{#441923} Committed: https://chromium.googlesource.com/chromium/src/+/c1751e0b4be0106ef84dcde9ab48816bfa74a95a

Patch Set 1 #

Total comments: 2

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -382 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPagePrefs.java View 1 chunk +0 lines, -122 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java View 10 chunks +10 lines, -14 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPagePrefs.java View 9 chunks +26 lines, -26 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/android/ntp/new_tab_page_prefs.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/android/ntp/new_tab_page_prefs.cc View 1 chunk +0 lines, -117 lines 0 comments Download
A + chrome/browser/android/ntp/recent_tabs_page_prefs.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/android/ntp/recent_tabs_page_prefs.cc View 7 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 11 months ago (2017-01-05 15:14:49 UTC) #4
Bernhard Bauer
lgtm https://codereview.chromium.org/2612243002/diff/1/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/2612243002/diff/1/chrome/browser/prefs/browser_prefs.cc#newcode572 chrome/browser/prefs/browser_prefs.cc:572: RecentTabsPagePrefs::RegisterProfilePrefs(registry); Can you move this to after PartnerBookmarksShim, ...
3 years, 11 months ago (2017-01-05 17:50:00 UTC) #7
Michael van Ouwerkerk
https://codereview.chromium.org/2612243002/diff/1/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/2612243002/diff/1/chrome/browser/prefs/browser_prefs.cc#newcode572 chrome/browser/prefs/browser_prefs.cc:572: RecentTabsPagePrefs::RegisterProfilePrefs(registry); On 2017/01/05 17:50:00, Bernhard Bauer wrote: > Can ...
3 years, 11 months ago (2017-01-06 10:23:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612243002/20001
3 years, 11 months ago (2017-01-06 10:23:35 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 12:17:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c1751e0b4be0106ef84dcde9ab48...

Powered by Google App Engine
This is Rietveld 408576698