Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2612213002: [crankshaft] Fix abstract equality for receivers. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix abstract equality for receivers. We need to check both sides for abstract equality of receivers in optimized code, otherwise we don't handle implicit conversions and undetectable objects correctly. R=jarin@chromium.org BUG=v8:5802 Review-Url: https://codereview.chromium.org/2612213002 Cr-Commit-Position: refs/heads/master@{#42085} Committed: https://chromium.googlesource.com/v8/v8/+/0957241060b01ee6c1ea7eeb87ec10889e6c37cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -15 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +27 lines, -15 lines 0 comments Download
A test/mjsunit/regress/regress-5802.js View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-05 09:01:23 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-05 09:08:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612213002/1
3 years, 11 months ago (2017-01-05 09:09:47 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 09:26:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0957241060b01ee6c1ea7eeb87ec10889e6...

Powered by Google App Engine
This is Rietveld 408576698