Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2612193002: Chrome Windows Debugger Extension Skeleton (Closed)

Created:
3 years, 11 months ago by robliao
Modified:
3 years, 11 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, robliao+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome Windows Debugger Extension Skeleton This is a skeleton of a Chrome Windows Debugger extension that will provide convenience commands for developers using ntsd, cdb, or windbg. BUG= Review-Url: https://codereview.chromium.org/2612193002 Cr-Commit-Position: refs/heads/master@{#443414} Committed: https://chromium.googlesource.com/chromium/src/+/fd54b5ccf9c4e391de0bcfe8e852f6784e1a9268

Patch Set 1 #

Total comments: 10

Patch Set 2 : CR Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M WATCHLISTS View 2 chunks +4 lines, -0 lines 0 comments Download
A tools/win/chromeexts/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/win/chromeexts/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A tools/win/chromeexts/chromeexts.cc View 1 1 chunk +88 lines, -0 lines 0 comments Download
A tools/win/chromeexts/chromeexts.def View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 11 months ago (2017-01-05 08:03:21 UTC) #5
scottmg
Doesn't seem too Chrome-specific yet, but I assume you have plans to add Aura details ...
3 years, 11 months ago (2017-01-05 15:53:46 UTC) #10
robliao
Thanks for the review! > Doesn't seem too Chrome-specific yet, but I assume you have ...
3 years, 11 months ago (2017-01-06 02:31:06 UTC) #11
robliao
brettw@chromium.org: Please review changes in /BUILD.gn. Thanks!
3 years, 11 months ago (2017-01-06 02:31:33 UTC) #13
brettw
lgtm
3 years, 11 months ago (2017-01-12 22:52:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612193002/40001
3 years, 11 months ago (2017-01-12 23:04:18 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:42:19 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd54b5ccf9c4e391de0bcfe8e852...

Powered by Google App Engine
This is Rietveld 408576698