Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2612113003: Revert of Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize(). (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize(). (patchset #1 id:1 of https://codereview.chromium.org/2600873002/ ) Reason for revert: This appears to be causing the layout test failures in crbug.com/678684. (Ran a local bisect to find the culprit.) Original issue's description: > Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize(). > > This is the second try to fix a performance regression of menulist rendering. > The first try [1] didn't have major improvement. This CL reverts it, and cache > another value. > > [1] crrev.com/438496 > > BUG=673754 > > Committed: https://crrev.com/b1f1c5d7ee4bfe822c4c0a384a9ac2ddaa71554f > Cr-Commit-Position: refs/heads/master@{#441569} TBR=keishi@chromium.org,tkent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673754 Review-Url: https://codereview.chromium.org/2612113003 Cr-Commit-Position: refs/heads/master@{#441739} Committed: https://chromium.googlesource.com/chromium/src/+/912bfe0a6472b47cec3271f2e9f21f0a3f9074c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +10 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Devlin
Created Revert of Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize().
3 years, 11 months ago (2017-01-05 19:53:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612113003/1
3 years, 11 months ago (2017-01-05 19:54:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/912bfe0a6472b47cec3271f2e9f21f0a3f9074c1
3 years, 11 months ago (2017-01-05 19:55:56 UTC) #6
tkent
3 years, 11 months ago (2017-01-09 23:15:20 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698