Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2612113002: Removing ServerWindowCompositorFrameSinkManager::ShouldDraw() (Closed)

Created:
3 years, 11 months ago by mfomitchev
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, sadrul, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing ServerWindowCompositorFrameSinkManager::ShouldDraw() With underlay surfaces unused/going away, ServerWindowCompositorFrameSinkManager should always draw. BUG=NONE

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -34 lines) Patch
M ash/mus/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/interfaces/mus_constants.mojom View 1 chunk +1 line, -6 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 2 chunks +0 lines, -12 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +1 line, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
mfomitchev
3 years, 11 months ago (2017-01-04 22:16:11 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-04 22:20:00 UTC) #5
sky
+tsepez for mojom
3 years, 11 months ago (2017-01-04 22:20:40 UTC) #8
Tom Sepez
RS LGTM on deleting code.
3 years, 11 months ago (2017-01-04 22:48:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612113002/1
3 years, 11 months ago (2017-01-06 05:31:02 UTC) #13
commit-bot: I haz the power
Failed to apply patch for services/ui/ws/frame_generator.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-06 06:24:07 UTC) #15
sadrul
3 years, 11 months ago (2017-01-10 06:34:32 UTC) #16

Powered by Google App Engine
This is Rietveld 408576698