Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2612093003: Rename m_fontSize *variable* to currentFontSize. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename m_fontSize *variable* to currentFontSize. This is needed to avoid a conflict after automatic renaming done by rewrite_to_chrome_style clang tool that would rename 2 local variables to the same new name. Specifically, the tool would: - Rename |fontSize| variable on line 65 to |font_size| - Rename |m_fontSize| variable on line 72 to |font_size| This CL preemptively avoids the problem described above, by manually renaming |m_fontSize| variable to |currentFontSize|. BUG=641004 Committed: https://crrev.com/0fa434091907b99a0fa6fb96b5b85ca1a2519d25 Cr-Commit-Position: refs/heads/master@{#441520}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove the no longer needed |this->| part. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Łukasz Anforowicz
cbiesinger@, could you PTAL?
3 years, 11 months ago (2017-01-04 22:21:39 UTC) #4
cbiesinger
lgtm https://codereview.chromium.org/2612093003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp File third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp (right): https://codereview.chromium.org/2612093003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp#newcode72 third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp:72: volatile float& currentFontSize = this->m_fontSize; I don't think ...
3 years, 11 months ago (2017-01-04 22:30:42 UTC) #5
Łukasz Anforowicz
Thanks. https://codereview.chromium.org/2612093003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp File third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp (right): https://codereview.chromium.org/2612093003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp#newcode72 third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp:72: volatile float& currentFontSize = this->m_fontSize; On 2017/01/04 22:30:42, ...
3 years, 11 months ago (2017-01-04 22:35:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612093003/20001
3 years, 11 months ago (2017-01-04 22:35:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 23:56:57 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:59:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fa434091907b99a0fa6fb96b5b85ca1a2519d25
Cr-Commit-Position: refs/heads/master@{#441520}

Powered by Google App Engine
This is Rietveld 408576698