Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Issue 2612083004: Revert "gn: Remove Scheduler::pool()." (Closed)

Created:
3 years, 11 months ago by tsniatowski
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, rginda+watch_chromium.org, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "gn: Remove Scheduler::pool()." This reverts commit 5476ec6bf7ccbada1734a0cdec7d570bb042aa30. Reason: that change causes GN to occasionally fail to load any input files, especially when there is load on the build machine. Errors look like: ERROR No targets. I could not find any targets to write, so I'm doing nothing. usually preceeded by a stray "Build argument has no effect" warning. Original issue: https://codereview.chromium.org/2515383005 BUG=674213 R=brettw@chromium.org,dpranke@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/gn/input_file_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tsniatowski
3 years, 11 months ago (2017-01-05 10:58:17 UTC) #1
fdoray
How can we repro this and verify that the revert fixes the problem?
3 years, 11 months ago (2017-01-06 22:31:39 UTC) #2
Dirk Pranke
On 2017/01/06 22:31:39, fdoray wrote: > How can we repro this and verify that the ...
3 years, 11 months ago (2017-01-06 22:36:43 UTC) #3
brettw
This is awesome! After digging into why this fixes the issue I will post a ...
3 years, 11 months ago (2017-01-06 23:45:04 UTC) #4
brettw
Alternative fix in https://codereview.chromium.org/2617253002
3 years, 11 months ago (2017-01-06 23:55:34 UTC) #5
tsniatowski
3 years, 11 months ago (2017-01-10 08:49:52 UTC) #7
On 2017/01/06 23:55:34, brettw (ping after 24h) wrote:
> Alternative fix in https://codereview.chromium.org/2617253002

Dropping this because the issues were fixed on master without needing a revert.

Powered by Google App Engine
This is Rietveld 408576698