Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: components/display_compositor/gpu_display_compositor_frame_sink.cc

Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/display_compositor/gpu_display_compositor_frame_sink.cc
diff --git a/components/display_compositor/gpu_display_compositor_frame_sink.cc b/components/display_compositor/gpu_display_compositor_frame_sink.cc
index 892409ae369cd840595326f16913f18883547427..fa37354e29ed496a225f8df3740899db312b88c4 100644
--- a/components/display_compositor/gpu_display_compositor_frame_sink.cc
+++ b/components/display_compositor/gpu_display_compositor_frame_sink.cc
@@ -20,15 +20,17 @@ GpuDisplayCompositorFrameSink::GpuDisplayCompositorFrameSink(
: GpuCompositorFrameSink(delegate,
surface_manager,
frame_sink_id,
- std::move(display),
- std::move(begin_frame_source),
+ display.get(),
std::move(compositor_frame_sink_private_request),
std::move(client)),
binding_(this, std::move(request)),
- display_private_binding_(this, std::move(display_private_request)) {
+ display_private_binding_(this, std::move(display_private_request)),
+ display_(std::move(display)),
+ display_begin_frame_source_(std::move(begin_frame_source)) {
danakj 2017/02/07 19:34:44 This BFS is used by the display, not by this class
danakj 2017/02/07 19:36:07 Oh the Display is owned here too I see.
Alex Z. 2017/02/07 19:40:19 Done.
binding_.set_connection_error_handler(
base::Bind(&GpuDisplayCompositorFrameSink::OnClientConnectionLost,
base::Unretained(this)));
+ display_->SetVisible(true);
}
GpuDisplayCompositorFrameSink::~GpuDisplayCompositorFrameSink() = default;

Powered by Google App Engine
This is Rietveld 408576698