DirectCompositorFrameSink Uses CompositorFrameSinkSupport

components/display_compositor/gpu_display_compositor_frame_sink.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/display_compositor/gpu_display_compositor_frame_sink.h"
 
 namespace display_compositor {
 
 GpuDisplayCompositorFrameSink::GpuDisplayCompositorFrameSink(
     GpuCompositorFrameSinkDelegate* delegate,
     cc::SurfaceManager* surface_manager,
     const cc::FrameSinkId& frame_sink_id,
     std::unique_ptr<cc::Display> display,
     std::unique_ptr<cc::BeginFrameSource> begin_frame_source,
     cc::mojom::MojoCompositorFrameSinkAssociatedRequest request,
     cc::mojom::MojoCompositorFrameSinkPrivateRequest
         compositor_frame_sink_private_request,
     cc::mojom::MojoCompositorFrameSinkClientPtr client,
     cc::mojom::DisplayPrivateAssociatedRequest display_private_request)
     : GpuCompositorFrameSink(delegate,
                              surface_manager,
                              frame_sink_id,
-                             std::move(display),
-                             std::move(begin_frame_source),
+                             display.get(),
                              std::move(compositor_frame_sink_private_request),
                              std::move(client)),
       binding_(this, std::move(request)),
-      display_private_binding_(this, std::move(display_private_request)) {
+      display_private_binding_(this, std::move(display_private_request)),
+      display_(std::move(display)),
+      display_begin_frame_source_(std::move(begin_frame_source)) {

[danakj, 2017/02/07 19:34:44]

This BFS is used by the display, not by this class. Before this CL it was owned
in the same places as the Display. Can we maintain that?

[danakj, 2017/02/07 19:36:07]

Oh the Display is owned here too I see.

[Alex Z., 2017/02/07 19:40:19]

Done.

   binding_.set_connection_error_handler(
       base::Bind(&GpuDisplayCompositorFrameSink::OnClientConnectionLost,
                  base::Unretained(this)));
+  display_->SetVisible(true);
 }
 
 GpuDisplayCompositorFrameSink::~GpuDisplayCompositorFrameSink() = default;
 
 void GpuDisplayCompositorFrameSink::SetDisplayVisible(bool visible) {
   DCHECK(support_.display());
   support_.display()->SetVisible(visible);

[danakj, 2017/02/07 19:39:53]

All of these can go thru display_-> now

[Alex Z., 2017/02/07 20:00:13]

Done.

 }
 
 void GpuDisplayCompositorFrameSink::ResizeDisplay(const gfx::Size& size) {
   DCHECK(support_.display());
   support_.display()->Resize(size);
 }
 
 void GpuDisplayCompositorFrameSink::SetDisplayColorSpace(
     const gfx::ColorSpace& color_space) {
   DCHECK(support_.display());
   support_.display()->SetColorSpace(color_space);
 }
 
 void GpuDisplayCompositorFrameSink::SetOutputIsSecure(bool secure) {
   DCHECK(support_.display());
   support_.display()->SetOutputIsSecure(secure);
 }
 
 }  // namespace display_compositor