DirectCompositorFrameSink Uses CompositorFrameSinkSupport

components/display_compositor/gpu_compositor_frame_sink.cc

Index: components/display_compositor/gpu_compositor_frame_sink.cc
diff --git a/components/display_compositor/gpu_compositor_frame_sink.cc b/components/display_compositor/gpu_compositor_frame_sink.cc
index 9a6347f146602e13ddc0e7a36ba5759fb34f825f..37e8a9d95d6c3267ccd0bbaa16ac0ddd7c1f479b 100644
--- a/components/display_compositor/gpu_compositor_frame_sink.cc
+++ b/components/display_compositor/gpu_compositor_frame_sink.cc
@@ -12,17 +12,12 @@ GpuCompositorFrameSink::GpuCompositorFrameSink(
     GpuCompositorFrameSinkDelegate* delegate,
     cc::SurfaceManager* surface_manager,
     const cc::FrameSinkId& frame_sink_id,
-    std::unique_ptr<cc::Display> display,
-    std::unique_ptr<cc::BeginFrameSource> begin_frame_source,
+    cc::Display* display,
     cc::mojom::MojoCompositorFrameSinkPrivateRequest
         compositor_frame_sink_private_request,
     cc::mojom::MojoCompositorFrameSinkClientPtr client)
     : delegate_(delegate),
-      support_(this,
-               surface_manager,
-               frame_sink_id,
-               std::move(display),
-               std::move(begin_frame_source)),
+      support_(this, surface_manager, frame_sink_id, display, true, true),

[Fady Samuel, 2017/02/07 17:42:18]

Please specify what these trues mean: e.g. true /*
handles_frame_sink_id_invalidation */, true /* needs_sync_points*/

[Alex Z., 2017/02/07 17:47:50]

Done.

[danakj, 2017/02/07 17:47:55]

can you put a comment beside these boolean literals to say what they are? always
document boolean literals as function arguments either with a temp var (not
possible here) or a comment

[Alex Z., 2017/02/07 17:51:33]

Done.

       surface_manager_(surface_manager),
       surface_tracker_(frame_sink_id),
       client_(std::move(client)),