DirectCompositorFrameSink Uses CompositorFrameSinkSupport

components/display_compositor/gpu_compositor_frame_sink.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/display_compositor/gpu_compositor_frame_sink.h"
 
 #include "cc/surfaces/surface_reference.h"
 
 namespace display_compositor {
 
 GpuCompositorFrameSink::GpuCompositorFrameSink(
     GpuCompositorFrameSinkDelegate* delegate,
     cc::SurfaceManager* surface_manager,
     const cc::FrameSinkId& frame_sink_id,
-    std::unique_ptr<cc::Display> display,
-    std::unique_ptr<cc::BeginFrameSource> begin_frame_source,
+    cc::Display* display,
     cc::mojom::MojoCompositorFrameSinkPrivateRequest
         compositor_frame_sink_private_request,
     cc::mojom::MojoCompositorFrameSinkClientPtr client)
     : delegate_(delegate),
-      support_(this,
-               surface_manager,
-               frame_sink_id,
-               std::move(display),
-               std::move(begin_frame_source)),
+      support_(this, surface_manager, frame_sink_id, display, true, true),

[Fady Samuel, 2017/02/07 17:42:18]

Please specify what these trues mean: e.g. true /*
handles_frame_sink_id_invalidation */, true /* needs_sync_points*/

[Alex Z., 2017/02/07 17:47:50]

Done.

[danakj, 2017/02/07 17:47:55]

can you put a comment beside these boolean literals to say what they are? always
document boolean literals as function arguments either with a temp var (not
possible here) or a comment

[Alex Z., 2017/02/07 17:51:33]

Done.

       surface_manager_(surface_manager),
       surface_tracker_(frame_sink_id),
       client_(std::move(client)),
       compositor_frame_sink_private_binding_(
           this,
           std::move(compositor_frame_sink_private_request)) {
   compositor_frame_sink_private_binding_.set_connection_error_handler(
       base::Bind(&GpuCompositorFrameSink::OnPrivateConnectionLost,
                  base::Unretained(this)));
 }
@@ skipping 108 matching lines @@
 }
 
 void GpuCompositorFrameSink::OnPrivateConnectionLost() {
   private_connection_lost_ = true;
   // Request destruction of |this| only if both connections are lost.
   delegate_->OnPrivateConnectionLost(support_.frame_sink_id(),
                                      client_connection_lost_);
 }
 
 }  // namespace display_compositor