Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: cc/surfaces/compositor_frame_sink_support.h

Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)
Patch Set: Addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/surfaces/compositor_frame_sink_support.cc » ('j') | ui/android/window_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/compositor_frame_sink_support.h
diff --git a/cc/surfaces/compositor_frame_sink_support.h b/cc/surfaces/compositor_frame_sink_support.h
index 8471bbd15c6b186b1c4678f6f64a7246ab41fd18..30ddb3a1aa4fbdb9b571c1262b0b26cac9e8301a 100644
--- a/cc/surfaces/compositor_frame_sink_support.h
+++ b/cc/surfaces/compositor_frame_sink_support.h
@@ -26,12 +26,11 @@ class CC_SURFACES_EXPORT CompositorFrameSinkSupport
public SurfaceFactoryClient,
public BeginFrameObserver {
public:
- CompositorFrameSinkSupport(
- CompositorFrameSinkSupportClient* client,
- SurfaceManager* surface_manager,
- const FrameSinkId& frame_sink_id,
- std::unique_ptr<Display> display,
- std::unique_ptr<BeginFrameSource> display_begin_frame_source);
+ CompositorFrameSinkSupport(CompositorFrameSinkSupportClient* client,
+ SurfaceManager* surface_manager,
+ const FrameSinkId& frame_sink_id,
+ Display* display,
+ bool needs_sync_points = true);
~CompositorFrameSinkSupport() override;
@@ -46,8 +45,10 @@ class CC_SURFACES_EXPORT CompositorFrameSinkSupport
void Satisfy(const SurfaceSequence& sequence);
void AddChildFrameSink(const FrameSinkId& child_frame_sink_id);
void RemoveChildFrameSink(const FrameSinkId& child_frame_sink_id);
+ void SetNeedsSyncPoints(bool needs_sync_points);
Fady Samuel 2017/01/31 15:43:59 nit: delete.
Alex Z. 2017/01/31 15:58:02 Done.
+ void ForceReclaimResources();
- Display* display() { return display_.get(); }
+ Display* display() { return display_; }
private:
void DidReceiveCompositorFrameAck();
@@ -77,11 +78,7 @@ class CC_SURFACES_EXPORT CompositorFrameSinkSupport
const FrameSinkId frame_sink_id_;
- // GpuCompositorFrameSink holds a Display and its BeginFrameSource if it
- // created with non-null gpu::SurfaceHandle. In the window server, the display
- // root window's CompositorFrameSink will have a valid gpu::SurfaceHandle.
- std::unique_ptr<BeginFrameSource> display_begin_frame_source_;
- std::unique_ptr<Display> display_;
+ Display* display_;
SurfaceFactory surface_factory_;
// Counts the number of CompositorFrames that have been submitted and have not
« no previous file with comments | « no previous file | cc/surfaces/compositor_frame_sink_support.cc » ('j') | ui/android/window_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698