ui/android/window_android.cc - Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/window_android.cc

Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)

Patch Set: Addressed comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/window_android.cc

diff --git a/ui/android/window_android.cc b/ui/android/window_android.cc

index 8a0c8c368ff47df37ddff87326fe0b8819359655..8b7d132a00c369170675c5f1001d4744dd938dce 100644

--- a/ui/android/window_android.cc

+++ b/ui/android/window_android.cc

@@ -177,9 +177,9 @@ void WindowAndroid::AttachCompositor(WindowAndroidCompositor* compositor) {

}

void WindowAndroid::DetachCompositor() {

- compositor_ = NULL;

for (WindowAndroidObserver& observer : observer_list_)

observer.OnDetachCompositor();

+ compositor_ = NULL;

Fady Samuel 2017/01/31 15:43:59 nit: nullptr while you're moving this code.

Alex Z. 2017/01/31 15:58:02 Done.

observer_list_.Clear();

}