webrtc-internals: show ice candidate type

webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292
Review-Url: https://codereview.chromium.org/2612063002
Cr-Commit-Position: refs/heads/master@{#443534}
Committed: https://chromium.googlesource.com/chromium/src/+/6947bf33fca57e328ba961b246cb1b386da6c706

[fippo, 2017-01-04 16:15:48]

Description was changed from

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=
==========

to

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=
==========

[fippo, 2017-01-04 16:15:48]

philipp.hancke@googlemail.com changed reviewers:
+ hta@chromium.org, tommi@chromium.org

[fippo, 2017-01-04 16:20:36]

This makes it a little easier to check if people gathered relay candidates when
they get ice failures

[tommi (sloooow) - chröme, 2017-01-04 16:53:17]

This seems useful.  Can you file a bug so that we can track this?

[fippo, 2017-01-04 17:26:34]

Description was changed from

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=
==========

to

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292
==========

[fippo, 2017-01-04 17:29:11]

On 2017/01/04 16:53:17, tommi (chrömium) wrote:
> This seems useful.  Can you file a bug so that we can track this?

done, set BUG= also backfilled that on the other issue

[tommi (sloooow) - chröme, 2017-01-04 17:41:08]

lgtm

[tommi (sloooow) - chröme, 2017-01-04 17:41:14]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 17:41:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 17:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 17:50:31]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2017-01-04 20:43:14]

lgtm

[tommi (sloooow) - chröme, 2017-01-13 11:32:35]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2017-01-13 11:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 11:42:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484307155883160, "parent_rev":
"f58077a1aed579173033500375bdf51859d27836", "commit_rev":
"6947bf33fca57e328ba961b246cb1b386da6c706"}

[commit-bot: I haz the power, 2017-01-13 11:42:47]

Description was changed from

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292
==========

to

==========
webrtc-internals: show ice candidate type

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292

Review-Url: https://codereview.chromium.org/2612063002
Cr-Commit-Position: refs/heads/master@{#443534}
Committed:
https://chromium.googlesource.com/chromium/src/+/6947bf33fca57e328ba961b246cb...
==========

[commit-bot: I haz the power, 2017-01-13 11:42:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6947bf33fca57e328ba961b246cb...