Stop browse:social:twitter scrolling wrong element

Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

Depends on: https://codereview.chromium.org/2617503002/

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2612053002
Cr-Commit-Position: refs/heads/master@{#444024}
Committed: https://chromium.googlesource.com/chromium/src/+/b7e693f47396d9d20d205e8e1a53736d4bb1aa0b

[hjd, 2017-01-04 15:49:04]

Description was changed from

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

BUG=chromium:664515
==========

to

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[hjd, 2017-01-04 15:51:05]

hjd@chromium.org changed reviewers:
+ perezju@chromium.org

[hjd, 2017-01-04 15:51:05]

ptal, thanks!

[perezju, 2017-01-04 15:58:35]

lgtm

just add a note in the description and link to the catapult CL this depends on.

https://codereview.chromium.org/2612053002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory.py (right):

https://codereview.chromium.org/2612053002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory.py:51:
options.clear_sytem_cache_for_browser_and_profile_on_start = True
this looks line an unrelated change?

[hjd, 2017-01-04 16:33:47]

Description was changed from

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

Depends on: https://codereview.chromium.org/2617503002/

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[hjd, 2017-01-05 10:31:08]

On 2017/01/04 15:58:35, perezju wrote:
> lgtm
> 
> just add a note in the description and link to the catapult CL this depends
on.

Added.

>
https://codereview.chromium.org/2612053002/diff/1/tools/perf/benchmarks/memor...
> File tools/perf/benchmarks/memory.py (right):
> 
>
https://codereview.chromium.org/2612053002/diff/1/tools/perf/benchmarks/memor...
> tools/perf/benchmarks/memory.py:51:
> options.clear_sytem_cache_for_browser_and_profile_on_start = True
> this looks line an unrelated change?

Thanks, removed.

[hjd, 2017-01-17 10:29:11]

The CQ bit was checked by hjd@chromium.org

[hjd, 2017-01-17 10:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/2612053002/#ps20001
(title: "Remove random other commit.")

[commit-bot: I haz the power, 2017-01-17 10:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 11:19:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484648951651450,
"parent_rev": "271aea611498493977c8a810f6ba997e5311791c", "commit_rev":
"b7e693f47396d9d20d205e8e1a53736d4bb1aa0b"}

[commit-bot: I haz the power, 2017-01-17 11:20:26]

Description was changed from

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

Depends on: https://codereview.chromium.org/2617503002/

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Stop browse:social:twitter scrolling wrong element

At the moment the browse:social:twitter system health story
thinks that it is scrolling the body element but is actually
scrolling something else (since the body element is off-screen
its bounding rect is clipped to have zero height so we scroll
(width/2, 0/2) which is some other div). This happens to work
but is unexpected. We want to make scrolling a zero area div
an error however that would break this story so we first need
to update the story to use a manually specified container.

Depends on: https://codereview.chromium.org/2617503002/

BUG=chromium:664515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2612053002
Cr-Commit-Position: refs/heads/master@{#444024}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7e693f47396d9d20d205e8e1a53...
==========

[commit-bot: I haz the power, 2017-01-17 11:20:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b7e693f47396d9d20d205e8e1a53...