Import features.gypi into BUILD.gn

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b1b5de368fd5e5d569ddaa21eae6246a4d398ee4..469ae560273b3ba15a0157ac5d78a240f288f3e3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -5,11 +5,26 @@
 # TODO(jochen): These will need to be user-settable to support standalone V8
 # builds.
 v8_compress_startup_data = "off"
+v8_deprecation_warnings = false
+v8_enable_disassembler = false
+v8_enable_gdbjit = false
+v8_enable_handle_zapping = true
 v8_enable_i18n_support = true
+v8_enable_verify_heap = false
+v8_interpreted_regexp = false
+v8_object_print = false
+v8_postmortem_support = false
+v8_use_default_platform = true
+v8_use_snapshot = true
+
+if (is_debug) {
+  v8_enable_extra_checks = true
+} else {
+  v8_enable_extra_checks = false
+}
 
 # TODO(jochen): Add support for want_seperate_host_toolset.
-# TODO(jochen): Add support for v8_target_arch.
-# TODO(jochen): Add features.gypi and toolchain.gypi support.
+# TODO(jochen): Add toolchain.gypi support.
 
 
 ###############################################################################
@@ -28,12 +43,74 @@ config("internal_config") {
   }
 }
 
+config("features") {
+  visibility = ":*"  # Only targets in this file can depend on this.

[brettw, 2014/05/05 16:24:49]

Below here you'll want to say:
  defines = []
And then turn all of the assignments below into += so you can support more than
one flag.

+
+  if (v8_enable_disassembler == true) {

[brettw, 2014/05/05 16:24:49]

Delete the " = true" parts. It's an if statement like C++ so 
  if (foo) {
is sufficient.

+    defines = [
+      "ENABLE_DISASSEMBLER",
+    ]
+  }
+  if (v8_enable_gdbjit == true) {
+    defines = [
+      "ENABLE_GDB_JIT_INTERFACE",
+    ]
+  }
+  if (v8_object_print == true) {
+    defines = [
+      "OBJECT_PRINT",
+    ]
+  }
+  if (v8_enable_verify_heap == true) {
+    defines = [
+      "VERIFY_HEAP",
+    ]
+  }
+  if (v8_interpreted_regexp == true) {
+    defines = [
+      "V8_INTERPRETED_REGEXP",
+    ]
+  }
+  if (v8_deprecation_warnings == true) {
+    defines = [
+      "V8_DEPRECATION_WARNINGS",
+    ]
+  }
+  if (v8_enable_i18n_support == true) {
+    defines = [
+      "V8_I18N_SUPPORT",
+    ]
+  }
+  if (v8_use_default_platform == true) {
+    defines = [
+      "V8_USE_DEFAULT_PLATFORM",
+    ]
+  }
+  if (v8_compress_startup_data == "bz2") {
+    defines = [
+      'COMPRESS_STARTUP_DATA_BZ2',
+    ]
+  }
+  if (v8_enable_extra_checks == true) {
+    defines = [
+      "ENABLE_EXTRA_CHECKS",
+    ]
+  }
+  if (v8_enable_handle_zapping == true) {
+    defines = [
+      "ENABLE_HANDLE_ZAPPING",
+    ]
+  }
+}
+
 ###############################################################################
 # Actions
 #
 
 # TODO(jochen): Do actions need visibility settings as well?
 action("generate_trig_table") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/generate-trig-table.py"
 
   outputs = [
@@ -44,6 +121,8 @@ action("generate_trig_table") {
 }
 
 action("js2c") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
@@ -86,6 +165,8 @@ action("js2c") {
 }
 
 action("js2c_experimental") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
@@ -117,6 +198,8 @@ action("js2c_experimental") {
 }
 
 action("postmortem-metadata") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/gen-postmortem-metadata.py"
 
   sources = [
@@ -154,7 +237,7 @@ source_set("v8_nosnapshot") {
     "src/snapshot-empty.cc",
   ]
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 }
 
 source_set("v8_base") {
@@ -525,9 +608,6 @@ source_set("v8_base") {
   ]
 
   if (cpu_arch == "x86") {
-    # TODO(brettw) the GYP file has
-    #   or v8_target_arch=="mac" or OS=="mac"
-    # which I don't understand.
     sources += [
       "src/ia32/assembler-ia32-inl.h",
       "src/ia32/assembler-ia32.cc",
@@ -700,7 +780,7 @@ source_set("v8_base") {
     ]
   }
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 
   defines = []
   deps = []
@@ -778,7 +858,7 @@ executable("mksnapshot") {
     "src/mksnapshot.cc",
   ]
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 
   deps = [
     ":v8_base",