Import features.gypi into BUILD.gn

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(jochen): These will need to be user-settable to support standalone V8
 # builds.
 v8_compress_startup_data = "off"
+v8_deprecation_warnings = false
+v8_enable_disassembler = false
+v8_enable_gdbjit = false
+v8_enable_handle_zapping = true
 v8_enable_i18n_support = true
+v8_enable_verify_heap = false
+v8_interpreted_regexp = false
+v8_object_print = false
+v8_postmortem_support = false
+v8_use_default_platform = true
+v8_use_snapshot = true
+
+if (is_debug) {
+  v8_enable_extra_checks = true
+} else {
+  v8_enable_extra_checks = false
+}
 
 # TODO(jochen): Add support for want_seperate_host_toolset.
-# TODO(jochen): Add support for v8_target_arch.
-# TODO(jochen): Add features.gypi and toolchain.gypi support.
+# TODO(jochen): Add toolchain.gypi support.
 
 
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   include_dirs = [ "src" ]
 
   if (component_mode == "shared_library") {
     defines = [
       "BUILDING_V8_SHARED",
       "V8_SHARED",
     ]
   }
 }
 
+config("features") {
+  visibility = ":*"  # Only targets in this file can depend on this.

[brettw, 2014/05/05 16:24:49]

Below here you'll want to say:
  defines = []
And then turn all of the assignments below into += so you can support more than
one flag.

+
+  if (v8_enable_disassembler == true) {

[brettw, 2014/05/05 16:24:49]

Delete the " = true" parts. It's an if statement like C++ so 
  if (foo) {
is sufficient.

+    defines = [
+      "ENABLE_DISASSEMBLER",
+    ]
+  }
+  if (v8_enable_gdbjit == true) {
+    defines = [
+      "ENABLE_GDB_JIT_INTERFACE",
+    ]
+  }
+  if (v8_object_print == true) {
+    defines = [
+      "OBJECT_PRINT",
+    ]
+  }
+  if (v8_enable_verify_heap == true) {
+    defines = [
+      "VERIFY_HEAP",
+    ]
+  }
+  if (v8_interpreted_regexp == true) {
+    defines = [
+      "V8_INTERPRETED_REGEXP",
+    ]
+  }
+  if (v8_deprecation_warnings == true) {
+    defines = [
+      "V8_DEPRECATION_WARNINGS",
+    ]
+  }
+  if (v8_enable_i18n_support == true) {
+    defines = [
+      "V8_I18N_SUPPORT",
+    ]
+  }
+  if (v8_use_default_platform == true) {
+    defines = [
+      "V8_USE_DEFAULT_PLATFORM",
+    ]
+  }
+  if (v8_compress_startup_data == "bz2") {
+    defines = [
+      'COMPRESS_STARTUP_DATA_BZ2',
+    ]
+  }
+  if (v8_enable_extra_checks == true) {
+    defines = [
+      "ENABLE_EXTRA_CHECKS",
+    ]
+  }
+  if (v8_enable_handle_zapping == true) {
+    defines = [
+      "ENABLE_HANDLE_ZAPPING",
+    ]
+  }
+}
+
 ###############################################################################
 # Actions
 #
 
 # TODO(jochen): Do actions need visibility settings as well?
 action("generate_trig_table") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/generate-trig-table.py"
 
   outputs = [
     "$target_gen_dir/trig-table.cc"
   ]
 
   args = rebase_path(outputs, root_build_dir)
 }
 
 action("js2c") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
   # changes.
   source_prereqs = [ "tools/jsmin.py" ]
 
   sources = [
     "src/runtime.js",
     "src/v8natives.js",
     "src/array.js",
@@ skipping 22 matching lines @@
     sources += [ "src/i18n.js" ]
   }
 
   args =
     rebase_path(outputs, root_build_dir) +
     [ "EXPERIMENTAL", v8_compress_startup_data ] + 
     rebase_path(sources, root_build_dir)
 }
 
 action("js2c_experimental") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
   # changes.
   source_prereqs = [ "tools/jsmin.py" ]
 
   sources = [
     "src/macros.py",
     "src/symbol.js",
     "src/proxy.js",
@@ skipping 11 matching lines @@
     "$target_gen_dir/experimental-libraries.cc"
   ]
 
   args =
     rebase_path(outputs, root_build_dir) +
     [ "CORE", v8_compress_startup_data ] + 
     rebase_path(sources, root_build_dir)
 }
 
 action("postmortem-metadata") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
   script = "tools/gen-postmortem-metadata.py"
 
   sources = [
     "src/objects.h",
     "src/objects-inl.h",
   ]
 
   outputs = [
     "$target_gen_dir/debug-support.cc"
   ]
@@ skipping 17 matching lines @@
     ":v8_base",
   ]
 
   sources = [
     "$target_gen_dir/libraries.cc",
     "$target_gen_dir/experimental-libraries.cc",
     "$target_gen_dir/trig-table.cc",
     "src/snapshot-empty.cc",
   ]
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 }
 
 source_set("v8_base") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   sources = [
     "src/accessors.cc",
     "src/accessors.h",
     "src/allocation.cc",
     "src/allocation.h",
@@ skipping 350 matching lines @@
     "src/version.cc",
     "src/version.h",
     "src/vm-state-inl.h",
     "src/vm-state.h",
     "src/zone-inl.h",
     "src/zone.cc",
     "src/zone.h",
   ]
 
   if (cpu_arch == "x86") {
-    # TODO(brettw) the GYP file has
-    #   or v8_target_arch=="mac" or OS=="mac"
-    # which I don't understand.
     sources += [
       "src/ia32/assembler-ia32-inl.h",
       "src/ia32/assembler-ia32.cc",
       "src/ia32/assembler-ia32.h",
       "src/ia32/builtins-ia32.cc",
       "src/ia32/code-stubs-ia32.cc",
       "src/ia32/code-stubs-ia32.h",
       "src/ia32/codegen-ia32.cc",
       "src/ia32/codegen-ia32.h",
       "src/ia32/cpu-ia32.cc",
@@ skipping 152 matching lines @@
       "src/mips/lithium-mips.h",
       "src/mips/macro-assembler-mips.cc",
       "src/mips/macro-assembler-mips.h",
       "src/mips/regexp-macro-assembler-mips.cc",
       "src/mips/regexp-macro-assembler-mips.h",
       "src/mips/simulator-mips.cc",
       "src/mips/stub-cache-mips.cc",
     ]
   }
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 
   defines = []
   deps = []
 
   if (is_posix) {
     sources += [
       "src/platform-posix.cc"
     ]
   }
 
@@ skipping 57 matching lines @@
   ]
 }
 
 } else {
 
 executable("mksnapshot") {
   sources = [
     "src/mksnapshot.cc",
   ]
 
-  configs += [ ":internal_config" ]
+  configs += [ ":internal_config", ":features" ]
 
   deps = [
     ":v8_base",
     ":v8_nosnapshot",
   ]
 
   if (v8_compress_startup_data == "bz2") {
     libs = [ "bz2" ]
   }
 }
 
 }