Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 261203003: Import features.gypi into BUILD.gn (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
v8-dev
Visibility:
Public.

Description

Import features.gypi into BUILD.gn BUG=none R=brettw@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21175

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -8 lines) Patch
M BUILD.gn View 9 chunks +88 lines, -8 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-05 12:41:46 UTC) #1
brettw
lgtm https://codereview.chromium.org/261203003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/261203003/diff/1/BUILD.gn#newcode47 BUILD.gn:47: visibility = ":*" # Only targets in this ...
6 years, 7 months ago (2014-05-05 16:24:49 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-06 15:01:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698