Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2612023003: don't need native-drawing-context for CanvasSkiaPaint (Closed)

Created:
3 years, 11 months ago by reed1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

don't need native-drawing-context for CanvasSkiaPaint BUG=675977 Committed: https://crrev.com/4c5054aecae9bb99c972e7cca364053a99c4df39 Cr-Commit-Position: refs/heads/master@{#441392}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add DCHECKs #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ui/gfx/canvas_paint_mac.mm View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
reed1
3 years, 11 months ago (2017-01-04 14:08:04 UTC) #2
reed1
3 years, 11 months ago (2017-01-04 14:09:34 UTC) #6
f(malita)
lgtm https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm File ui/gfx/canvas_paint_mac.mm (right): https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm#newcode31 ui/gfx/canvas_paint_mac.mm:31: bool peek = canvas->peekPixels(&pixmap); DCHECK(peek)?
3 years, 11 months ago (2017-01-04 14:31:36 UTC) #8
reed1
https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm File ui/gfx/canvas_paint_mac.mm (right): https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm#newcode31 ui/gfx/canvas_paint_mac.mm:31: bool peek = canvas->peekPixels(&pixmap); On 2017/01/04 14:31:36, f(malita) wrote: ...
3 years, 11 months ago (2017-01-04 14:48:23 UTC) #11
Avi (use Gerrit)
lgtm If the experts are happy, stamp stamp
3 years, 11 months ago (2017-01-04 16:32:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612023003/40001
3 years, 11 months ago (2017-01-04 16:36:27 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 16:41:36 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:45:19 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c5054aecae9bb99c972e7cca364053a99c4df39
Cr-Commit-Position: refs/heads/master@{#441392}

Powered by Google App Engine
This is Rietveld 408576698