|
|
Descriptiondon't need native-drawing-context for CanvasSkiaPaint
BUG=675977
Committed: https://crrev.com/4c5054aecae9bb99c972e7cca364053a99c4df39
Cr-Commit-Position: refs/heads/master@{#441392}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add DCHECKs #Patch Set 3 : rebase #Messages
Total messages: 22 (14 generated)
reed@google.com changed reviewers: + fmalita@chromium.org
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reed@google.com changed reviewers: + avi@chromium.org, ccameron@chromium.org
Description was changed from ========== don't need native-drawing-context for CanvasSkiaPaint BUG= ========== to ========== don't need native-drawing-context for CanvasSkiaPaint BUG=675977 ==========
lgtm https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm File ui/gfx/canvas_paint_mac.mm (right): https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm#... ui/gfx/canvas_paint_mac.mm:31: bool peek = canvas->peekPixels(&pixmap); DCHECK(peek)?
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm File ui/gfx/canvas_paint_mac.mm (right): https://codereview.chromium.org/2612023003/diff/1/ui/gfx/canvas_paint_mac.mm#... ui/gfx/canvas_paint_mac.mm:31: bool peek = canvas->peekPixels(&pixmap); On 2017/01/04 14:31:36, f(malita) wrote: > DCHECK(peek)? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm If the experts are happy, stamp stamp
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2612023003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483547769664250, "parent_rev": "4f0834b23eabc76d275c4393f791b451b1ee5ab3", "commit_rev": "437ccc235abea0d654d3a5aac6910cb0a586d14f"}
Message was sent while issue was closed.
Description was changed from ========== don't need native-drawing-context for CanvasSkiaPaint BUG=675977 ========== to ========== don't need native-drawing-context for CanvasSkiaPaint BUG=675977 Review-Url: https://codereview.chromium.org/2612023003 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== don't need native-drawing-context for CanvasSkiaPaint BUG=675977 Review-Url: https://codereview.chromium.org/2612023003 ========== to ========== don't need native-drawing-context for CanvasSkiaPaint BUG=675977 Committed: https://crrev.com/4c5054aecae9bb99c972e7cca364053a99c4df39 Cr-Commit-Position: refs/heads/master@{#441392} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4c5054aecae9bb99c972e7cca364053a99c4df39 Cr-Commit-Position: refs/heads/master@{#441392} |