Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2612013002: [asm.js] [inspector-test] Avoid breakpoint on "use asm" statement (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asm.js] [inspector-test] Avoid breakpoint on "use asm" statement Ignition does not emit any byte code for some literal expression statements, so avoid testing for it. R=rmcilroy@chromium.org BUG=v8:5757 Review-Url: https://codereview.chromium.org/2612013002 Cr-Commit-Position: refs/heads/master@{#42067} Committed: https://chromium.googlesource.com/v8/v8/+/20defd29e017df7019de9b00134c1c9565287723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M test/inspector/debugger/asm-js-breakpoint-before-exec.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/inspector/debugger/asm-js-breakpoint-before-exec-expected.txt View 2 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-04 13:04:12 UTC) #3
rmcilroy
Awesome, thanks Clemens! LGTM
3 years, 11 months ago (2017-01-04 13:25:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612013002/1
3 years, 11 months ago (2017-01-04 13:27:59 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 13:29:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/20defd29e017df7019de9b00134c1c95652...

Powered by Google App Engine
This is Rietveld 408576698