[parser] Reduce excessive inlining.

[parser] Reduce excessive inlining.

The inlining does not seem to actually improve performance, and hence outlining makes the code a bit more readable.

Performance + binary size appear to be at least as good as with inlining. On gcc I get several 10kBs savings in binary size, but only ~100B on clang. In no case have I observed a performance regression.

R=marja@chromium.org
BUG=v8:3437
Review-Url: https://codereview.chromium.org/2611993002
Cr-Commit-Position: refs/heads/master@{#42276}
Committed: https://chromium.googlesource.com/v8/v8/+/778cf612dc54459be3831fd2b6f8e8d365c98b5f

[vogelheim, 2017-01-04 11:50:21]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 11:50:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 12:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 12:16:13]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-05 09:29:43]

lgtm

you could include the rationale in the description

[vogelheim, 2017-01-12 15:45:49]

Description was changed from

==========
[parser] Reduce excessive inlining.

R=marja@chromium.org
BUG=v8:3437
==========

to

==========
[parser] Reduce excessive inlining.

The inlining does not seem to actually improve performance, and hence outlining
makes the code a bit more readable.

Performance + binary size appear to be at least as good as with inlining. On gcc
I get several 10kBs savings in binary size, but only ~100B on clang. In no case
have I observed a performance regression.

R=marja@chromium.org
BUG=v8:3437
==========

[vogelheim, 2017-01-12 15:45:55]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:22:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484235955315400, "parent_rev":
"75a2fce3a2ad5a9857f1dd203b95b857c7fa12f1", "commit_rev":
"778cf612dc54459be3831fd2b6f8e8d365c98b5f"}

[commit-bot: I haz the power, 2017-01-12 16:22:57]

Description was changed from

==========
[parser] Reduce excessive inlining.

The inlining does not seem to actually improve performance, and hence outlining
makes the code a bit more readable.

Performance + binary size appear to be at least as good as with inlining. On gcc
I get several 10kBs savings in binary size, but only ~100B on clang. In no case
have I observed a performance regression.

R=marja@chromium.org
BUG=v8:3437
==========

to

==========
[parser] Reduce excessive inlining.

The inlining does not seem to actually improve performance, and hence outlining
makes the code a bit more readable.

Performance + binary size appear to be at least as good as with inlining. On gcc
I get several 10kBs savings in binary size, but only ~100B on clang. In no case
have I observed a performance regression.

R=marja@chromium.org
BUG=v8:3437

Review-Url: https://codereview.chromium.org/2611993002
Cr-Commit-Position: refs/heads/master@{#42276}
Committed:
https://chromium.googlesource.com/v8/v8/+/778cf612dc54459be3831fd2b6f8e8d365c...
==========

[commit-bot: I haz the power, 2017-01-12 16:22:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/778cf612dc54459be3831fd2b6f8e8d365c...