Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2611943003: Early return in ::SetTooltipText in case GetView returns null (Closed)

Created:
3 years, 11 months ago by tonikitoo
Modified:
3 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early return in ::SetTooltipText in case GetView returns null Driven by change: there is no point in doing the wrapping of the tooltip text with RTL/LTR formatting, in case there is no view. Simply bail out earlier. BUG= Review-Url: https://codereview.chromium.org/2611943003 Cr-Commit-Position: refs/heads/master@{#441784} Committed: https://chromium.googlesource.com/chromium/src/+/b21270407f03c618ce6b187dacd743e359d998d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tonikitoo
PTAL
3 years, 11 months ago (2017-01-04 21:04:48 UTC) #5
sadrul
lgtm
3 years, 11 months ago (2017-01-05 21:01:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611943003/1
3 years, 11 months ago (2017-01-05 21:03:33 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:22:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b21270407f03c618ce6b187dacd7...

Powered by Google App Engine
This is Rietveld 408576698