Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2611923002:
Disable copy and assignment for DisplayItemClient (Closed)
|
Created:
3 years, 11 months ago by Xianzhu Modified:
3 years, 11 months ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable copy and assignment for DisplayItemClient
The copy constructor breaks DisplayItemClient aliveness checking.
We could fix the copy constructor but it looks better not to support
the copy constructor.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/69682c5cde36d77da49233aa408ccf953126848a
Cr-Commit-Position: refs/heads/master@{#441432}
Patch Set 1 #Patch Set 2 : - #Messages
Total messages: 19 (14 generated)
Description was changed from ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. ========== to ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org
On 2017/01/04 at 19:04:48, wangxianzhu wrote: > LGTM
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483557609555820,
"parent_rev": "23db8e34e9d25c18cc207e84093c01112afbaadc", "commit_rev":
"b26ed2c3f7133b7eb6bc33a8b319ebd7ccf5c611"}
Message was sent while issue was closed.
Description was changed from ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2611923002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2611923002 ========== to ========== Disable copy and assignment for DisplayItemClient The copy constructor breaks DisplayItemClient aliveness checking. We could fix the copy constructor but it looks better not to support the copy constructor. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/69682c5cde36d77da49233aa408ccf953126848a Cr-Commit-Position: refs/heads/master@{#441432} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/69682c5cde36d77da49233aa408ccf953126848a Cr-Commit-Position: refs/heads/master@{#441432} |
