Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2611913002: Tweak CryptauthDeviceManager to store fetched BeaconSeed data in Base64URL encoding, and retrieve i… (Closed)

Created:
3 years, 11 months ago by Ryan Hansberry
Modified:
3 years, 11 months ago
Reviewers:
Kyle Horimoto
CC:
chromium-reviews, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, jlklein+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, tengs+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak CryptauthDeviceManager to store fetched BeaconSeed data in Base64URL encoding, and retrieve it as raw data. This is necessary because CryptauthDeviceManager assumed that BeacondSeed data from the server was Base64 encoded, when in reality it was raw. BUG=678145 Committed: https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b Cr-Commit-Position: refs/heads/master@{#441450}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M components/cryptauth/cryptauth_device_manager.cc View 1 3 chunks +25 lines, -12 lines 0 comments Download
M components/cryptauth/cryptauth_device_manager_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M components/cryptauth/eid_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/cryptauth/eid_generator_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Ryan Hansberry
3 years, 11 months ago (2017-01-04 18:24:08 UTC) #3
Kyle Horimoto
lgtm https://codereview.chromium.org/2611913002/diff/1/components/cryptauth/cryptauth_device_manager.cc File components/cryptauth/cryptauth_device_manager.cc (right): https://codereview.chromium.org/2611913002/diff/1/components/cryptauth/cryptauth_device_manager.cc#newcode71 components/cryptauth/cryptauth_device_manager.cc:71: // Note that the beacon seeds' data is ...
3 years, 11 months ago (2017-01-04 18:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611913002/20001
3 years, 11 months ago (2017-01-04 18:56:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 20:16:33 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 20:19:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b
Cr-Commit-Position: refs/heads/master@{#441450}

Powered by Google App Engine
This is Rietveld 408576698