Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2611853002: [Cronet] Provide shim from deprecated cronet_c_for_grpc API to bidirectional_stream_c API. (Closed)

Created:
3 years, 11 months ago by mef
Modified:
3 years, 11 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Provide shim from deprecated cronet_c_for_grpc.h API to bidirectional_stream_c.h API on iOS. BUG=650462 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/233f9faa257fdad767900274a66b67160ee66094 Cr-Commit-Position: refs/heads/master@{#441509}

Patch Set 1 #

Patch Set 2 : Use #define instead of typedef and function forwarders. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M components/cronet/ios/BUILD.gn View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/cronet/ios/Cronet.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_c_for_grpc.h View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
kapishnikov
lgtm
3 years, 11 months ago (2017-01-04 21:30:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611853002/20001
3 years, 11 months ago (2017-01-04 23:28:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 23:35:25 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:38:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/233f9faa257fdad767900274a66b67160ee66094
Cr-Commit-Position: refs/heads/master@{#441509}

Powered by Google App Engine
This is Rietveld 408576698