Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2611843010: DevTools: move DOMExtension.js into ui module. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
chenwilliam, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move DOMExtension.js into ui module. Review-Url: https://codereview.chromium.org/2611843010 Cr-Commit-Position: refs/heads/master@{#442103} Committed: https://chromium.googlesource.com/chromium/src/+/51b59b3aa445abf8ed7d378d565136b602d1726b

Patch Set 1 #

Patch Set 2 : Introduce progress monitor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -874 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/FileUtils.js View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/module.json View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js View 1 chunk +0 lines, -833 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/ui/DOMExtension.js View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
pfeldman
3 years, 11 months ago (2017-01-06 19:36:31 UTC) #2
alph
lgtm
3 years, 11 months ago (2017-01-06 19:48:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611843010/1
3 years, 11 months ago (2017-01-06 19:53:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/366298)
3 years, 11 months ago (2017-01-06 21:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611843010/20001
3 years, 11 months ago (2017-01-06 22:06:28 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 00:10:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/51b59b3aa445abf8ed7d378d5651...

Powered by Google App Engine
This is Rietveld 408576698