Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2611843007: Update incremental install docs. (Closed)

Created:
3 years, 11 months ago by estevenson
Modified:
3 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update incremental install docs. Docs now include instructions for using the incremental_apk_by_default GN arg and mention that Webview and Monochrome aren't supported. BUG= Review-Url: https://codereview.chromium.org/2611843007 Cr-Commit-Position: refs/heads/master@{#441677} Committed: https://chromium.googlesource.com/chromium/src/+/75e9b86472ac55d4a8a41150eeda026d76659fdc

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M docs/android_build_instructions.md View 1 3 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
estevenson
ptal Andrew
3 years, 11 months ago (2017-01-05 16:16:26 UTC) #2
agrieve
lgtm. Please also add a bit more to your cl description though (make it mention ...
3 years, 11 months ago (2017-01-05 16:26:40 UTC) #3
estevenson
Thanks! https://codereview.chromium.org/2611843007/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2611843007/diff/1/docs/android_build_instructions.md#newcode351 docs/android_build_instructions.md:351: ```ninja -C out/Default foo_apk out/Default/bin/install_foo_apk_incremental```). On 2017/01/05 16:26:40, ...
3 years, 11 months ago (2017-01-05 16:36:48 UTC) #5
estevenson
Thanks! https://codereview.chromium.org/2611843007/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2611843007/diff/1/docs/android_build_instructions.md#newcode351 docs/android_build_instructions.md:351: ```ninja -C out/Default foo_apk out/Default/bin/install_foo_apk_incremental```). On 2017/01/05 16:26:40, ...
3 years, 11 months ago (2017-01-05 16:36:48 UTC) #6
estevenson
Thanks!
3 years, 11 months ago (2017-01-05 16:36:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611843007/20001
3 years, 11 months ago (2017-01-05 16:37:42 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 16:49:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75e9b86472ac55d4a8a41150eeda...

Powered by Google App Engine
This is Rietveld 408576698