DevTools: fix --debug-devtools flag for npm test

DevTools: fix --debug-devtools flag for npm test

Fixes a regression where --debug-devtools erroneously no longer used the debug version
of devtools (e.g. minified / unbundled).

Also added an npm command to debug test: "npm run debug-test inspector/test-name.html"

BUG=none

Review-Url: https://codereview.chromium.org/2611843003
Cr-Commit-Position: refs/heads/master@{#441763}
Committed: https://chromium.googlesource.com/chromium/src/+/e4fe80178e0f20f1f70be8190f11b97133dfb09b

[chenwilliam, 2017-01-04 18:08:01]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2017-01-04 18:08:01]

PTAL.

[pfeldman, 2017-01-05 01:48:01]

lgtm

[chenwilliam, 2017-01-05 02:44:24]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:45:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 03:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:49:32]

Failed to apply patch for
third_party/WebKit/Source/devtools/scripts/npm_test.js:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/devtools/scripts/npm_test.js:38
  error: third_party/WebKit/Source/devtools/scripts/npm_test.js: patch does not
apply

Patch:       third_party/WebKit/Source/devtools/scripts/npm_test.js
Index: third_party/WebKit/Source/devtools/scripts/npm_test.js
diff --git a/third_party/WebKit/Source/devtools/scripts/npm_test.js
b/third_party/WebKit/Source/devtools/scripts/npm_test.js
index
701c21ae6dc5292d001468a7320357000827bd97..b493f0c7ad34e7b6a853d1e0dabf3d4f0a368c85
100644
--- a/third_party/WebKit/Source/devtools/scripts/npm_test.js
+++ b/third_party/WebKit/Source/devtools/scripts/npm_test.js
@@ -38,7 +38,7 @@ function main(){
             console.log("Compiling devtools frontend");
             shell(`ninja -C ${RELEASE_PATH} devtools_frontend_resources`);
         }
-        runTests(outDir, false);
+        runTests(outDir, IS_DEBUG_ENABLED);
         return;
     }
     if (!utils.isDir(CACHE_PATH))
@@ -233,6 +233,8 @@ function runTests(buildDirectoryPath, useDebugDevtools)
     ]);
     if (useDebugDevtools) {
         testArgs.push("--additional-driver-flag=--debug-devtools");
+    } else {
+        console.log("TIP: You can debug a test using: npm run debug-test
inspector/test-name.html")
     }
     if (IS_DEBUG_ENABLED) {
         testArgs.push("--additional-driver-flag=--remote-debugging-port=9222");

[chenwilliam, 2017-01-05 20:23:29]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-05 20:23:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2611843003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-05 20:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:37:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483647809119340,
"parent_rev": "7563580907ed85a7ec511bedc8a293ab5951cf03", "commit_rev":
"e4fe80178e0f20f1f70be8190f11b97133dfb09b"}

[commit-bot: I haz the power, 2017-01-05 21:38:31]

Description was changed from

==========
DevTools: fix --debug-devtools flag for npm test

Fixes a regression where --debug-devtools erroneously no longer used the debug
version
of devtools (e.g. minified / unbundled).

Also added an npm command to debug test: "npm run debug-test
inspector/test-name.html"

BUG=none
==========

to

==========
DevTools: fix --debug-devtools flag for npm test

Fixes a regression where --debug-devtools erroneously no longer used the debug
version
of devtools (e.g. minified / unbundled).

Also added an npm command to debug test: "npm run debug-test
inspector/test-name.html"

BUG=none

Review-Url: https://codereview.chromium.org/2611843003
Cr-Commit-Position: refs/heads/master@{#441763}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4fe80178e0f20f1f70be8190f11...
==========

[commit-bot: I haz the power, 2017-01-05 21:38:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4fe80178e0f20f1f70be8190f11...