ABANDONED CL: Changes to compile and pass tests after Big Blink Rename (excluding functions).

ABANDONED CL - We won't need this CL anymore, since the Great Blink Rename has already landed - yay!

================

Changes to compile and pass tests after Big Blink Rename (excluding functions).

This CL makes things compile and pass tests after Big Blink Rename that
excludes/skips renaming of functions and methods.  There is a companion
CL at https://codereview.chromium.org/2329463004 that contains changes
needed after a full Big Blink Rename (full = also renaming functions and
methods).

This CL is for things
1. That cannot be prelanded
   (in Blink or in the RewriteToChromeStyle tool).
2. The need to be manually applied and landed together
   with the Big Blink Rename.

Some things are not clear-cut (e.g. can we preland changes under
third_party/WebKit/Source/bindings).  Some changes are not yet complete
(e.g. changing check_webkit_style.py).

BUG=644384

[Łukasz Anforowicz, 2017-01-04 19:02:53]

Description was changed from

==========
Changes to compile and pass tests after Big Blink Rename (excluding functions).

This CL is for things
1. That cannot be prelanded (in Blink or in the RewriteToChromeStyle tool).
2. The need to be manually applied and together with the Big Blink Rename.

Some things are not clear-cut (e.g. can we preland changes under
third_party/WebKit/Source/bindings).  Some changes are not yet complete
(e.g. changing check_webkit_style.py).

BUG=644384
==========

to

==========
Changes to compile and pass tests after Big Blink Rename (excluding functions).

This CL makes things compile and pass tests after Big Blink Rename that
excludes/skips renaming of functions and methods.  There is a companion
CL at https://codereview.chromium.org/2329463004 that contains changes
needed after a full Big Blink Rename (full = also renaming functions and
methods).

This CL is for things
1. That cannot be prelanded
   (in Blink or in the RewriteToChromeStyle tool).
2. The need to be manually applied and landed together
   with the Big Blink Rename.

Some things are not clear-cut (e.g. can we preland changes under
third_party/WebKit/Source/bindings).  Some changes are not yet complete
(e.g. changing check_webkit_style.py).

BUG=644384
==========

[Łukasz Anforowicz, 2017-01-04 22:11:24]

https://codereview.chromium.org/2611823003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
(right):

https://codereview.chromium.org/2611823003/diff/20001/content/browser/rendere...
content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc:87: for
(size_t i = 0; i < webkit_items_length_cap; i++) {
This probably got missed by the tool, because I have enable_nacl = false in my
args.gn (supposedly this helps with build performance - I heard it on
chromium-dev [I think] so it must be true...).

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp (right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp:11:
static_assert(offsetof(struct WrapperTypeInfo, gin_embedder) ==
This probably didn't get rewritten because of |offsetof(...)| - AFAICT this is
one of only 2 places under third_party/WebKit/Source that use |offsetof(...)|
and the only one that is affected by the rename (the other one is in
platform/heap/StackFrameDepth.cpp and is for OS-specific, non-Blink fields).

Based on the above, I don't plan to spend time trying to make
RewriteToChromeStyle work with this.

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValue.h (right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValue.h:45:
GCInfoTrait<CSSValue>::index(), kTypeName);
CSSValueArenaIndex wasn't rewritten because this identifier is built via macro
token concatenation in Source/platform/heap/BlinkGC.h - #define
TypedArenaEnumName(Type) k##Type##ArenaIndex.

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp (right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp:312: code_point_func
= kCodePoints[cc];
Not sure why this wasn't handled by the tool.  Declaration is in checked-in code
(in third_party/WebKit/Source/core/css/parser/CSSTokenizer.h:101).  Definition
is in generated code (in gen/blink/core/CSSTokenizerCodepoints.cpp).

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp (right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp:171:
TEST_TOKENS("]", right_bracket());
Not sure why the tool didn't rename things here.

Maybe because TEST_TOKENS uses variadic arguments: #define TEST_TOKENS(string,
...)

Maybe because leftParenthesis is defined via a macro: #define DEFINE_TOKEN(name,
argument)

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp (right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp:75: return
current_font_size != old_font_size;
Interesting case - renaming renamed m_fontSize (local variable) -> font_size and
this would have shadowed another renamed variable above.  So - I need to rename.
 This could be prelanded.

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2611823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:75:
static const char kLtrDirectionString[] = "ltr";
The 3 lines above can probably be prelanded.

[dominicc (has gone to gerrit), 2017-01-13 05:15:59]

dominicc@chromium.org changed reviewers:
+ dominicc@chromium.org

[dominicc (has gone to gerrit), 2017-01-13 05:16:00]

lgtm

core/dom, core/editing, core/html, core/xml LGTM modulo 
third_party/WebKit/Source/core/editing/commands/EditorCommandNames.h has "do not
land" stuff on it.

The XPath parser stuff has to land at the same time as renaming in XPathParser.h
naturally.

V0CustomElementLifecycleCallbacks non-owner LGTM

[kouhei (in TOK), 2017-01-13 05:16:53]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2017-01-13 05:16:54]

core/html/parser lgtm

[Łukasz Anforowicz, 2017-04-14 16:32:00]

Description was changed from

==========
Changes to compile and pass tests after Big Blink Rename (excluding functions).

This CL makes things compile and pass tests after Big Blink Rename that
excludes/skips renaming of functions and methods.  There is a companion
CL at https://codereview.chromium.org/2329463004 that contains changes
needed after a full Big Blink Rename (full = also renaming functions and
methods).

This CL is for things
1. That cannot be prelanded
   (in Blink or in the RewriteToChromeStyle tool).
2. The need to be manually applied and landed together
   with the Big Blink Rename.

Some things are not clear-cut (e.g. can we preland changes under
third_party/WebKit/Source/bindings).  Some changes are not yet complete
(e.g. changing check_webkit_style.py).

BUG=644384
==========

to

==========
ABANDONED CL - We won't need this CL anymore, since the Great Blink Rename has
already landed - yay!

================

Changes to compile and pass tests after Big Blink Rename (excluding functions).

This CL makes things compile and pass tests after Big Blink Rename that
excludes/skips renaming of functions and methods.  There is a companion
CL at https://codereview.chromium.org/2329463004 that contains changes
needed after a full Big Blink Rename (full = also renaming functions and
methods).

This CL is for things
1. That cannot be prelanded
   (in Blink or in the RewriteToChromeStyle tool).
2. The need to be manually applied and landed together
   with the Big Blink Rename.

Some things are not clear-cut (e.g. can we preland changes under
third_party/WebKit/Source/bindings).  Some changes are not yet complete
(e.g. changing check_webkit_style.py).

BUG=644384
==========