Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2611823003: ABANDONED CL: Changes to compile and pass tests after Big Blink Rename (excluding functions). (Closed)
Patch Set: Inducing merge conflicts to force human review and changes after rename. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 if (interface.name in ['Window', 'WorkerGlobalScope'] and 447 if (interface.name in ['Window', 'WorkerGlobalScope'] and
448 attribute.name == 'onerror'): 448 attribute.name == 'onerror'):
449 includes.add('bindings/core/v8/V8ErrorHandler.h') 449 includes.add('bindings/core/v8/V8ErrorHandler.h')
450 arguments.append( 450 arguments.append(
451 'V8EventListenerHelper::ensureEventListener<V8ErrorHandler>(' + 451 'V8EventListenerHelper::ensureEventListener<V8ErrorHandler>(' +
452 'v8Value, true, ScriptState::forReceiverObject(info))') 452 'v8Value, true, ScriptState::forReceiverObject(info))')
453 else: 453 else:
454 arguments.append( 454 arguments.append(
455 'V8EventListenerHelper::getEventListener(' + 455 'V8EventListenerHelper::getEventListener(' +
456 'ScriptState::forReceiverObject(info), v8Value, true, ' + 456 'ScriptState::forReceiverObject(info), v8Value, true, ' +
457 'ListenerFindOrCreate)') 457 'kListenerFindOrCreate)')
458 else: 458 else:
459 arguments.append('cppValue') 459 arguments.append('cppValue')
460 if context['is_setter_raises_exception']: 460 if context['is_setter_raises_exception']:
461 arguments.append('exceptionState') 461 arguments.append('exceptionState')
462 462
463 return '%s(%s)' % (setter_name, ', '.join(arguments)) 463 return '%s(%s)' % (setter_name, ', '.join(arguments))
464 464
465 465
466 CONTENT_ATTRIBUTE_SETTER_NAMES = { 466 CONTENT_ATTRIBUTE_SETTER_NAMES = {
467 'boolean': 'setBooleanAttribute', 467 'boolean': 'setBooleanAttribute',
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 lambda self: strip_suffix(self.base_type, 'Constructor')) 566 lambda self: strip_suffix(self.base_type, 'Constructor'))
567 567
568 568
569 def is_constructor_attribute(attribute): 569 def is_constructor_attribute(attribute):
570 # FIXME: replace this with [ConstructorAttribute] extended attribute 570 # FIXME: replace this with [ConstructorAttribute] extended attribute
571 return attribute.idl_type.name.endswith('Constructor') 571 return attribute.idl_type.name.endswith('Constructor')
572 572
573 573
574 def update_constructor_attribute_context(interface, attribute, context): 574 def update_constructor_attribute_context(interface, attribute, context):
575 context['needs_constructor_getter_callback'] = context['measure_as'] or cont ext['deprecate_as'] 575 context['needs_constructor_getter_callback'] = context['measure_as'] or cont ext['deprecate_as']
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698