Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2611823002: Fix flaky automatic-pull-node test (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky automatic-pull-node test This test is incorrect and flaky because it was depending on the context being rendered before the test function was called. BUG=678069 TEST=automatic-pull-node.html Committed: https://crrev.com/26fdde80ab962b093cc9a45819ae86187261abe5 Cr-Commit-Position: refs/heads/master@{#441506}

Patch Set 1 #

Patch Set 2 : Use anon functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-03 21:25:29 UTC) #2
hongchan
lgtm
3 years, 11 months ago (2017-01-04 21:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611823002/20001
3 years, 11 months ago (2017-01-04 22:20:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 23:28:50 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:32:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26fdde80ab962b093cc9a45819ae86187261abe5
Cr-Commit-Position: refs/heads/master@{#441506}

Powered by Google App Engine
This is Rietveld 408576698