chrome/browser/usb/usb_chooser_controller_unittest.cc - Issue 2611773004: Allow top-level frames to request any USB device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/usb_chooser_controller_unittest.cc

Issue 2611773004: Allow top-level frames to request any USB device. (Closed)

Patch Set: Add comments explaining how the mock devices are being used. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/usb/usb_chooser_controller_unittest.cc

diff --git a/chrome/browser/usb/usb_chooser_controller_unittest.cc b/chrome/browser/usb/usb_chooser_controller_unittest.cc

index bcf2c3c02a88dd2c461febfa20293f2ac68f2d60..78fc50fa2745520115c0215eca84e89776413814 100644

--- a/chrome/browser/usb/usb_chooser_controller_unittest.cc

+++ b/chrome/browser/usb/usb_chooser_controller_unittest.cc

@@ -54,7 +54,7 @@ class UsbChooserControllerTest : public ChromeRenderViewHostTestHarness {

content::WebContentsTester::For(web_contents());

web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));

usb_chooser_controller_.reset(new UsbChooserController(

- main_rfh(), std::move(device_filters), main_rfh(), callback));

+ main_rfh(), std::move(device_filters), callback));

mock_usb_chooser_view_.reset(new MockUsbChooserView());

usb_chooser_controller_->set_view(mock_usb_chooser_view_.get());

}