Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2611763002: Add define for staging SkFontMgr factory update. (Closed)

Created:
3 years, 11 months ago by bungeman-chromium
Modified:
3 years, 11 months ago
Reviewers:
bungeman-skia
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add define for staging SkFontMgr factory update. The SkFontMgr factories currently all return bare pointers. Skia is updating these to smart pointers to clarify ownership, but this change needs to be staged. This CL simply adds a define which will be used for this transition. Committed: https://crrev.com/b1c6e29b423601ad93ae57b5da0b6077f9bb85ec Cr-Commit-Position: refs/heads/master@{#441232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M skia/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bungeman-skia
lgtm
3 years, 11 months ago (2017-01-03 19:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611763002/1
3 years, 11 months ago (2017-01-03 19:09:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 22:53:47 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:56:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c6e29b423601ad93ae57b5da0b6077f9bb85ec
Cr-Commit-Position: refs/heads/master@{#441232}

Powered by Google App Engine
This is Rietveld 408576698