Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2611753003: Rename blink::Page's load deferral to suspension (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Rename blink::Page's load deferral to suspension This CL renames: * ScopedPageLoadDeferrer to ScopedPageSuspender, * blink::Page::defersLoading() to suspended(), and * blink::Page::setDefersLoading() to setSuspended(). blink::setDefersLoading does not only defer loadings, but also suspends all associated ExecutionContext and ActiveDOMObjects. Review-Url: https://codereview.chromium.org/2526163002 Cr-Commit-Position: refs/heads/master@{#434378} (cherry picked from commit 5ad6641ca96fc131e8268f649bc6db71170ad736) BUG=671102 Committed: https://chromium.googlesource.com/chromium/src/+/fad76601729f6b957274071fb0f1d33072ab72c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -202 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ScopedPageSuspender.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 3 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dcheng
3 years, 11 months ago (2017-01-03 21:42:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fad76601729f6b957274071fb0f1d33072ab72c1.

Powered by Google App Engine
This is Rietveld 408576698