[heap] Enter final pause for embedder tracer in MarkLiveObjects

[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause could then trigger
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2611753002
Cr-Commit-Position: refs/heads/master@{#42044}
Committed: https://chromium.googlesource.com/v8/v8/+/d75023f3a1f24498b05c361a62a7513e0918edcb

[Michael Lippautz, 2017-01-03 18:50:10]

Description was changed from

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause would then call
Heap::RegisterExternallyReferencedObject which rightfully  fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
==========

to

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause would then call
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
==========

[Michael Lippautz, 2017-01-03 18:51:11]

Description was changed from

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause would then call
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
==========

to

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause would then call
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org
==========

[Michael Lippautz, 2017-01-03 18:51:12]

mlippautz@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Lippautz, 2017-01-03 18:51:40]

Description was changed from

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause would then call
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org
==========

to

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause could then trigger
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org
==========

[Michael Lippautz, 2017-01-03 18:51:57]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:52:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:20:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483469517033820, "parent_rev":
"a0eb5ab5fc79a2a14aeecab07e0e960249d39e0e", "commit_rev":
"d75023f3a1f24498b05c361a62a7513e0918edcb"}

[commit-bot: I haz the power, 2017-01-03 19:20:40]

Description was changed from

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause could then trigger
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org
==========

to

==========
[heap] Enter final pause for embedder tracer in MarkLiveObjects

MarkCompactCollector::Prepare is too early in the rare case that we don't have a
marking deque yet. EnterFinalPause could then trigger
Heap::RegisterExternallyReferencedObject which rightfully fails because MC is
not properly set up.

Note that the DCHECK also triggers, without actual consequences, for aborting
incremental marking.

BUG=468240
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2611753002
Cr-Commit-Position: refs/heads/master@{#42044}
Committed:
https://chromium.googlesource.com/v8/v8/+/d75023f3a1f24498b05c361a62a7513e091...
==========

[commit-bot: I haz the power, 2017-01-03 19:20:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d75023f3a1f24498b05c361a62a7513e091...