Add 'DirectionString' suffix to |rtl|, |ltr| and |inherit| constant identifiers.

Add 'DirectionString' suffix to |rtl|, |ltr| and |inherit| constant identifiers.

After automatic rename by rewrite_to_chrome_style clang tool, the |rtl|,
|ltr| and |inherit| constant identifiers in CanvasRenderingContext2D.cpp
would become |kRtl|, |kLtr|, |kInherit| and would unfortunately conflict
with identifiers defined elsewhere (e.g. with |kRtl| and |kLtr| enum
values from TextDirection enum defined in TextDirection.h).

This CL preemptively prevents the problem above, by adding a
'DirectionString' suffix to the 3 affected identifiers in
CanvasRenderingContext2D.cpp

BUG=641004
Review-Url: https://codereview.chromium.org/2611723004
Cr-Commit-Position: refs/heads/master@{#442088}
Committed: https://chromium.googlesource.com/chromium/src/+/149963d671825cc359fa59c489880036cd114f8e

[Łukasz Anforowicz, 2017-01-04 22:32:32]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 22:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-04 22:33:23]

lukasza@chromium.org changed reviewers:
+ junov@chromium.org

[Łukasz Anforowicz, 2017-01-04 22:33:23]

junov@, could you PTAL?

[commit-bot: I haz the power, 2017-01-05 00:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 00:08:47]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2017-01-06 20:09:15]

lgtm

[Łukasz Anforowicz, 2017-01-06 21:20:38]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:20:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:13:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483737638967200, "parent_rev":
"bdeb3debe066a16282163c61a581efde140ffbbc", "commit_rev":
"149963d671825cc359fa59c489880036cd114f8e"}

[commit-bot: I haz the power, 2017-01-06 23:14:04]

Description was changed from

==========
Add 'DirectionString' suffix to |rtl|, |ltr| and |inherit| constant identifiers.

After automatic rename by rewrite_to_chrome_style clang tool, the |rtl|,
|ltr| and |inherit| constant identifiers in CanvasRenderingContext2D.cpp
would become |kRtl|, |kLtr|, |kInherit| and would unfortunately conflict
with identifiers defined elsewhere (e.g. with |kRtl| and |kLtr| enum
values from TextDirection enum defined in TextDirection.h).

This CL preemptively prevents the problem above, by adding a
'DirectionString' suffix to the 3 affected identifiers in
CanvasRenderingContext2D.cpp

BUG=641004
==========

to

==========
Add 'DirectionString' suffix to |rtl|, |ltr| and |inherit| constant identifiers.

After automatic rename by rewrite_to_chrome_style clang tool, the |rtl|,
|ltr| and |inherit| constant identifiers in CanvasRenderingContext2D.cpp
would become |kRtl|, |kLtr|, |kInherit| and would unfortunately conflict
with identifiers defined elsewhere (e.g. with |kRtl| and |kLtr| enum
values from TextDirection enum defined in TextDirection.h).

This CL preemptively prevents the problem above, by adding a
'DirectionString' suffix to the 3 affected identifiers in
CanvasRenderingContext2D.cpp

BUG=641004

Review-Url: https://codereview.chromium.org/2611723004
Cr-Commit-Position: refs/heads/master@{#442088}
Committed:
https://chromium.googlesource.com/chromium/src/+/149963d671825cc359fa59c48988...
==========

[commit-bot: I haz the power, 2017-01-06 23:14:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/149963d671825cc359fa59c48988...