Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2611713002: Rewrite the layout test for DOMRect interface. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
zino
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite the layout test for DOMRect interface. For historical reasons, older tests are written using the js-test harness. This harness is deprecated, and should not be used for new tests. So, rewrite The layout test as following new tests guide[1]. [1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md#The-js_test_js-Legacy-Harness BUG=678023 Committed: https://crrev.com/b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa Cr-Commit-Position: refs/heads/master@{#441405}

Patch Set 1 #

Patch Set 2 : Rewrite the layout test for DOMRect interface. #

Patch Set 3 : Rewrite the layout test for DOMRect interface. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -286 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html View 1 1 chunk +53 lines, -152 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect-expected.txt View 1 chunk +0 lines, -134 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-04 14:46:01 UTC) #3
zino
lgtm
3 years, 11 months ago (2017-01-04 15:56:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611713002/20001
3 years, 11 months ago (2017-01-04 16:02:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/129926) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-04 16:04:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611713002/40001
3 years, 11 months ago (2017-01-04 16:22:49 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 17:54:32 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 17:58:01 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa
Cr-Commit-Position: refs/heads/master@{#441405}

Powered by Google App Engine
This is Rietveld 408576698